Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-17 Thread Philippe Mathieu-Daudé
On 17/1/24 12:53, Michael Tokarev wrote: 04.01.2024 01:51, Richard Henderson : On 1/4/24 01:37, Philippe Mathieu-Daudé wrote: Finally changing the constraints on op_rotli_vec seems to fix it: --- diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index fbee43d3b0..b3456fe857

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-17 Thread Alex Bennée
Michael Tokarev writes: > 04.01.2024 01:51, Richard Henderson : >> On 1/4/24 01:37, Philippe Mathieu-Daudé wrote: >>> Finally changing the constraints on op_rotli_vec seems to fix it: >>> >>> --- >>> diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc >>> index fbee43d3b0..b3456f

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-17 Thread Michael Tokarev
04.01.2024 01:51, Richard Henderson : On 1/4/24 01:37, Philippe Mathieu-Daudé wrote: Finally changing the constraints on op_rotli_vec seems to fix it: --- diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index fbee43d3b0..b3456fe857 100644 --- a/tcg/s390x/tcg-target.c.inc ++

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-03 Thread Richard Henderson
On 1/4/24 01:37, Philippe Mathieu-Daudé wrote: Finally changing the constraints on op_rotli_vec seems to fix it: --- diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index fbee43d3b0..b3456fe857 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -3264

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-03 Thread Philippe Mathieu-Daudé
On 3/1/24 15:01, Philippe Mathieu-Daudé wrote: On 3/1/24 12:53, Philippe Mathieu-Daudé wrote: Hi Richard, On 3/1/24 09:54, Michael Tokarev wrote: 03.01.2024 03:22, Richard Henderson wrote: On 12/22/23 01:51, Michael Tokarev wrote: ... git bisect points to this commit: commit ab84dc398b3b70

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-03 Thread Philippe Mathieu-Daudé
On 3/1/24 12:53, Philippe Mathieu-Daudé wrote: Hi Richard, On 3/1/24 09:54, Michael Tokarev wrote: 03.01.2024 03:22, Richard Henderson wrote: On 12/22/23 01:51, Michael Tokarev wrote: ... git bisect points to this commit: commit ab84dc398b3b702b0c692538b947ef65dbbdf52f Author: Richard Hende

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-03 Thread Philippe Mathieu-Daudé
Hi Richard, On 3/1/24 09:54, Michael Tokarev wrote: 03.01.2024 03:22, Richard Henderson wrote: On 12/22/23 01:51, Michael Tokarev wrote: ... git bisect points to this commit: commit ab84dc398b3b702b0c692538b947ef65dbbdf52f Author: Richard Henderson Date:   Wed Aug 23 23:04:24 2023 -0700   

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-03 Thread Michael Tokarev
03.01.2024 03:22, Richard Henderson wrote: On 12/22/23 01:51, Michael Tokarev wrote: ... git bisect points to this commit: commit ab84dc398b3b702b0c692538b947ef65dbbdf52f Author: Richard Henderson Date:   Wed Aug 23 23:04:24 2023 -0700 tcg/optimize: Optimize env memory operations So fa

Re: chacha20-s390 broken in 8.2.0 in TCG on s390x

2024-01-02 Thread Richard Henderson
On 12/22/23 01:51, Michael Tokarev wrote: When running current kernel on s390x in tcg mode *on s390x hw*, the following is generated when loading crypto selftest module (it gets loaded automatically): [   10.546690] alg: skcipher: chacha20-s390 encryption test failed (wrong result) on test vect