Re: Properly quitting qemu immediately after failing migration

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 14:44, Vladimir Sementsov-Ogievskiy wrote: 02.07.2020 10:23, Max Reitz wrote: On 01.07.20 18:16, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 18:00, Max Reitz wrote: On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 16:48, Max Reitz wrote: Hi, In an iotest, I’m

Re: Properly quitting qemu immediately after failing migration

2020-07-02 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 10:23, Max Reitz wrote: On 01.07.20 18:16, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 18:00, Max Reitz wrote: On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 16:48, Max Reitz wrote: Hi, In an iotest, I’m trying to quit qemu immediately after a migration has f

Re: Properly quitting qemu immediately after failing migration

2020-07-02 Thread Max Reitz
On 01.07.20 18:16, Vladimir Sementsov-Ogievskiy wrote: > 29.06.2020 18:00, Max Reitz wrote: >> On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote: >>> 29.06.2020 16:48, Max Reitz wrote: Hi, In an iotest, I’m trying to quit qemu immediately after a migration has failed.  Unfor

Re: Properly quitting qemu immediately after failing migration

2020-07-01 Thread Vladimir Sementsov-Ogievskiy
29.06.2020 18:00, Max Reitz wrote: On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote: 29.06.2020 16:48, Max Reitz wrote: Hi, In an iotest, I’m trying to quit qemu immediately after a migration has failed.  Unfortunately, that doesn’t seem to be possible in a clean way: migrate_fd_cleanup()

Re: Properly quitting qemu immediately after failing migration

2020-06-29 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 29.06.20 17:41, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> Hi, > >> > >> In an iotest, I’m trying to quit qemu immediately after a migration has > >> failed. Unfortunately, that doesn’t seem to be possible in a clean wa

Re: Properly quitting qemu immediately after failing migration

2020-06-29 Thread Max Reitz
On 29.06.20 17:41, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> Hi, >> >> In an iotest, I’m trying to quit qemu immediately after a migration has >> failed. Unfortunately, that doesn’t seem to be possible in a clean way: >> migrate_fd_cleanup() runs only at some point

Re: Properly quitting qemu immediately after failing migration

2020-06-29 Thread Max Reitz
On 29.06.20 17:45, Daniel P. Berrangé wrote: > On Mon, Jun 29, 2020 at 03:48:35PM +0200, Max Reitz wrote: >> In practice this particular issue might not be that big of a problem, >> because it just means qemu aborts when the user intended to let it quit >> anyway. But on one hand I could imagine t

Re: Properly quitting qemu immediately after failing migration

2020-06-29 Thread Daniel P . Berrangé
On Mon, Jun 29, 2020 at 03:48:35PM +0200, Max Reitz wrote: > In practice this particular issue might not be that big of a problem, > because it just means qemu aborts when the user intended to let it quit > anyway. But on one hand I could imagine that there are other clean-up > paths that should d

Re: Properly quitting qemu immediately after failing migration

2020-06-29 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > Hi, > > In an iotest, I’m trying to quit qemu immediately after a migration has > failed. Unfortunately, that doesn’t seem to be possible in a clean way: > migrate_fd_cleanup() runs only at some point after the migration state > is already “failed”, so if

Re: Properly quitting qemu immediately after failing migration

2020-06-29 Thread Max Reitz
On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote: > 29.06.2020 16:48, Max Reitz wrote: >> Hi, >> >> In an iotest, I’m trying to quit qemu immediately after a migration has >> failed.  Unfortunately, that doesn’t seem to be possible in a clean way: >> migrate_fd_cleanup() runs only at some poin

Re: Properly quitting qemu immediately after failing migration

2020-06-29 Thread Vladimir Sementsov-Ogievskiy
29.06.2020 16:48, Max Reitz wrote: Hi, In an iotest, I’m trying to quit qemu immediately after a migration has failed. Unfortunately, that doesn’t seem to be possible in a clean way: migrate_fd_cleanup() runs only at some point after the migration state is already “failed”, so if I just wait fo