Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-30 Thread Michael S. Tsirkin
On Wed, Aug 30, 2023 at 10:22:53AM +0200, Marcin Juszkiewicz wrote: > W dniu 29.08.2023 o 22:46, Michael S. Tsirkin pisze: > > On Tue, Aug 29, 2023 at 10:44:08PM +0200, Marcin Juszkiewicz wrote: > > > W dniu 29.08.2023 o 22:40, Michael S. Tsirkin pisze: > > > > > It passes with sbsa-ref (which is n

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-30 Thread Marcin Juszkiewicz
W dniu 29.08.2023 o 22:46, Michael S. Tsirkin pisze: On Tue, Aug 29, 2023 at 10:44:08PM +0200, Marcin Juszkiewicz wrote: W dniu 29.08.2023 o 22:40, Michael S. Tsirkin pisze: It passes with sbsa-ref (which is not using QEMU versioning). Fails (as expected) when used new property for each pcie-r

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 10:05:47PM +0200, Marcin Juszkiewicz wrote: > W dniu 29.08.2023 o 19:07, Michael S. Tsirkin pisze: > > > No - it depends on secondart bus type and only applies to bridges. > > Also we need compat machinery. > > Marcin could you pls test the following? > > Works fine: > >

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 10:31:25PM +0200, Marcin Juszkiewicz wrote: > W dniu 29.08.2023 o 22:18, Michael S. Tsirkin pisze: > > On Tue, Aug 29, 2023 at 10:05:47PM +0200, Marcin Juszkiewicz wrote: > > > W dniu 29.08.2023 o 19:07, Michael S. Tsirkin pisze: > > > > > > > No - it depends on secondart b

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Marcin Juszkiewicz
W dniu 29.08.2023 o 19:07, Michael S. Tsirkin pisze: No - it depends on secondart bus type and only applies to bridges. Also we need compat machinery. Marcin could you pls test the following? Works fine: 822 : Check Type 1 config header rules : Result: PASS diff --git a/include

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Marcin Juszkiewicz
W dniu 29.08.2023 o 22:40, Michael S. Tsirkin pisze: It passes with sbsa-ref (which is not using QEMU versioning). Fails (as expected) when used new property for each pcie-root-port (ignore line breaks): "-device pcie-root-port, x-pci-express-writeable-slt-bug=true, id=root30,chassis=30,s

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 10:44:08PM +0200, Marcin Juszkiewicz wrote: > W dniu 29.08.2023 o 22:40, Michael S. Tsirkin pisze: > > > It passes with sbsa-ref (which is not using QEMU versioning). > > > > > > Fails (as expected) when used new property for each pcie-root-port > > > (ignore line breaks):

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Marcin Juszkiewicz
W dniu 29.08.2023 o 22:18, Michael S. Tsirkin pisze: On Tue, Aug 29, 2023 at 10:05:47PM +0200, Marcin Juszkiewicz wrote: W dniu 29.08.2023 o 19:07, Michael S. Tsirkin pisze: No - it depends on secondart bus type and only applies to bridges. Also we need compat machinery. Marcin could you pls t

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 04:04:27PM +0200, Philippe Mathieu-Daudé wrote: > On 29/8/23 15:48, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2023 at 02:14:51PM +0100, Peter Maydell wrote: > > > On Tue, 29 Aug 2023 at 12:40, Marcin Juszkiewicz > > > wrote: > > > > > > > > I am working on aarch64/sbsa

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Marcin Juszkiewicz
W dniu 29.08.2023 o 15:57, Philippe Mathieu-Daudé pisze: On 29/8/23 13:39, Marcin Juszkiewicz wrote: Does someone know where the problem may be? And how to fix it? Commit fb23162885 ("pci: initialize pci config headers depending it pci header type.") sets PCI_SEC_LATENCY_TIMER writable; it s

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 15:48, Michael S. Tsirkin wrote: On Tue, Aug 29, 2023 at 02:14:51PM +0100, Peter Maydell wrote: On Tue, 29 Aug 2023 at 12:40, Marcin Juszkiewicz wrote: I am working on aarch64/sbsa-ref machine so people can have virtual machine to test their OS against something reminding standards

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 13:39, Marcin Juszkiewicz wrote: I am working on aarch64/sbsa-ref machine so people can have virtual machine to test their OS against something reminding standards compliant system. One of tools I use is BSA ACS (Base System Architecture - Architecture Compliance Suite) [1] written by

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 02:14:51PM +0100, Peter Maydell wrote: > On Tue, 29 Aug 2023 at 12:40, Marcin Juszkiewicz > wrote: > > > > I am working on aarch64/sbsa-ref machine so people can have virtual > > machine to test their OS against something reminding standards compliant > > system. > > > > On

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Peter Maydell
On Tue, 29 Aug 2023 at 12:40, Marcin Juszkiewicz wrote: > > I am working on aarch64/sbsa-ref machine so people can have virtual > machine to test their OS against something reminding standards compliant > system. > > One of tools I use is BSA ACS (Base System Architecture - Architecture > Complian