Re: Coverity CID 1421984

2020-03-23 Thread Peter Maydell
On Mon, 23 Mar 2020 at 15:28, BALATON Zoltan wrote: > Is this documented anywhere? Unfortunately not. You're quite right that we should document this (I hadn't realized/had forgotten that the qdev gpio APIs are entirely undocumented -- they date from a time when we were much less strict about ask

Re: Coverity CID 1421984

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/23/20 3:46 PM, Peter Maydell wrote: On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote: On Mon, 23 Mar 2020, Peter Maydell wrote: On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote: On Mon, 23 Mar 2020, Peter Maydell wrote: Coverity has flagged up a lot of leaks involving qemu_allocat

Re: Coverity CID 1421984

2020-03-23 Thread BALATON Zoltan
On Mon, 23 Mar 2020, Peter Maydell wrote: On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote: On Mon, 23 Mar 2020, Peter Maydell wrote: On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote: On Mon, 23 Mar 2020, Peter Maydell wrote: Coverity has flagged up a lot of leaks involving qemu_allocat

Re: Coverity CID 1421984

2020-03-23 Thread Peter Maydell
On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote: > > On Mon, 23 Mar 2020, Peter Maydell wrote: > > On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote: > >> On Mon, 23 Mar 2020, Peter Maydell wrote: > >>> Coverity has flagged up a lot of leaks involving qemu_allocate_irqs(); > >>> most of them

Re: Coverity CID 1421984

2020-03-23 Thread BALATON Zoltan
On Mon, 23 Mar 2020, Peter Maydell wrote: On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote: On Mon, 23 Mar 2020, Peter Maydell wrote: Coverity has flagged up a lot of leaks involving qemu_allocate_irqs(); most of them I've for the moment just set as "insignificant, fix required" because they

Re: Coverity CID 1421984

2020-03-23 Thread Peter Maydell
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote: > On Mon, 23 Mar 2020, Peter Maydell wrote: > > Coverity has flagged up a lot of leaks involving qemu_allocate_irqs(); > > most of them I've for the moment just set as "insignificant, fix > > required" because they're in called-once functions lik

Re: Coverity CID 1421984

2020-03-23 Thread BALATON Zoltan
On Mon, 23 Mar 2020, Peter Maydell wrote: On Mon, 23 Mar 2020 at 13:12, BALATON Zoltan wrote: On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote: Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board. On 3/23/20 12:46 PM, Max Reitz wrote: Hi, I was triaging new Coverity block l

Re: Coverity CID 1421984

2020-03-23 Thread Peter Maydell
On Mon, 23 Mar 2020 at 13:12, BALATON Zoltan wrote: > > On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote: > > Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board. > > On 3/23/20 12:46 PM, Max Reitz wrote: > >> Hi, > >> > >> I was triaging new Coverity block layer reports today, a

Re: Coverity CID 1421984

2020-03-23 Thread Max Reitz
On 23.03.20 14:11, BALATON Zoltan wrote: > On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote: >> Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board. >> On 3/23/20 12:46 PM, Max Reitz wrote: >>> Hi, >>> >>> I was triaging new Coverity block layer reports today, and one that >>> see

Re: Coverity CID 1421984

2020-03-23 Thread BALATON Zoltan
On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote: Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board. On 3/23/20 12:46 PM, Max Reitz wrote: Hi, I was triaging new Coverity block layer reports today, and one that seemed like a real bug was CID 1421984: It complains about a me

Re: Coverity CID 1421984

2020-03-23 Thread Philippe Mathieu-Daudé
Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board. On 3/23/20 12:46 PM, Max Reitz wrote: Hi, I was triaging new Coverity block layer reports today, and one that seemed like a real bug was CID 1421984: It complains about a memleak in sii3112_pci_realize() in hw/ide/sii3112.c,