Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-14 Thread Eugenio Perez Martin
On Thu, Jul 14, 2022 at 9:04 AM Jason Wang wrote: > > On Thu, Jul 14, 2022 at 2:54 PM Eugenio Perez Martin > wrote: > > > > > > > +static void vhost_vdpa_net_handle_ctrl_used(VhostShadowVirtqueue > > > > > *svq, > > > > > +void *vq_elem_opaque, > > > >

Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-14 Thread Jason Wang
On Thu, Jul 14, 2022 at 2:54 PM Eugenio Perez Martin wrote: > > > > > +static void vhost_vdpa_net_handle_ctrl_used(VhostShadowVirtqueue *svq, > > > > +void *vq_elem_opaque, > > > > +uint32_t dev_written) > > >

Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-13 Thread Eugenio Perez Martin
> > > +static void vhost_vdpa_net_handle_ctrl_used(VhostShadowVirtqueue *svq, > > > +void *vq_elem_opaque, > > > +uint32_t dev_written) > > > +{ > > > +g_autoptr(CVQElement) cvq_elem = vq_elem_opaque; > > >

Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-12 Thread Eugenio Perez Martin
On Tue, Jul 12, 2022 at 9:18 AM Jason Wang wrote: > > > 在 2022/7/7 02:40, Eugenio Pérez 写道: > > Introduce the control virtqueue support for vDPA shadow virtqueue. This > > is needed for advanced networking features like multiqueue. > > > > Virtio-net control VQ will copy the descriptors to qemu's

Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-12 Thread Jason Wang
在 2022/7/7 02:40, Eugenio Pérez 写道: Introduce the control virtqueue support for vDPA shadow virtqueue. This is needed for advanced networking features like multiqueue. Virtio-net control VQ will copy the descriptors to qemu's VA, so we avoid TOCTOU with the guest's or device's memory every tim