Re: [RFC PATCH v5 39/52] i386/xen: add monitor commands to test event injection

2023-01-09 Thread David Woodhouse
On Mon, 2023-01-09 at 18:51 +, Dr. David Alan Gilbert wrote: > * David Woodhouse (dw...@infradead.org) wrote: > > > > Thanks. Taking option 'a' then... > > Yes that's mostly right, some minor comments on it: > > > +EvtchnInfoList *qmp_xen_event_list(Error **errp) > > +{ > > +    error_setg(e

Re: [RFC PATCH v5 39/52] i386/xen: add monitor commands to test event injection

2023-01-09 Thread Dr. David Alan Gilbert
* David Woodhouse (dw...@infradead.org) wrote: > On Thu, 2023-01-05 at 20:09 +, Dr. David Alan Gilbert wrote: > > > > > OK... something like this? > > > > No; that's a bit of a mix: > > The idea is that you either: > >   a) Build the QMP with the data structure well defined like you've done >

Re: [RFC PATCH v5 39/52] i386/xen: add monitor commands to test event injection

2023-01-09 Thread David Woodhouse
On Thu, 2023-01-05 at 20:09 +, Dr. David Alan Gilbert wrote: > > > OK... something like this? > > No; that's a bit of a mix: > The idea is that you either: >   a) Build the QMP with the data structure well defined like you've done > and then make the HMP code monitor_printf that. > >  

Re: [RFC PATCH v5 39/52] i386/xen: add monitor commands to test event injection

2023-01-05 Thread Dr. David Alan Gilbert
* David Woodhouse (dw...@infradead.org) wrote: > On Wed, 2023-01-04 at 12:48 +, Dr. David Alan Gilbert wrote: > > * David Woodhouse (dw...@infradead.org) wrote: > > > From: Joao Martins > > > > > > Specifically add listing, injection of event channels. > > > > These are all for debug only ar

Re: [RFC PATCH v5 39/52] i386/xen: add monitor commands to test event injection

2023-01-05 Thread David Woodhouse
On Wed, 2023-01-04 at 12:48 +, Dr. David Alan Gilbert wrote: > * David Woodhouse (dw...@infradead.org) wrote: > > From: Joao Martins > > > > Specifically add listing, injection of event channels. > > These are all for debug only aren't they? Mostly. Injecting VIRQ_DEBUG into a guest is usef

Re: [RFC PATCH v5 39/52] i386/xen: add monitor commands to test event injection

2023-01-04 Thread Dr. David Alan Gilbert
* David Woodhouse (dw...@infradead.org) wrote: > From: Joao Martins > > Specifically add listing, injection of event channels. These are all for debug only aren't they? Even so, see docs/devel/writing-monitor-commands.rst, people like commands to be built around qmp if possible now; there's a t