Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-29 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Damien Hedde writes: > > Patches 1, 3 and 5 miss a review. > > > > The series is organized as follow: > > > > + Patches 1 and 2 converts the MachinePhase enum to a qapi definition > > and add the 'query-machine-phase'. It allows to introspect the

Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-25 Thread Daniel P . Berrangé
On Wed, Nov 24, 2021 at 03:51:23PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Nov 24, 2021 at 02:50:11PM +0100, Markus Armbruster wrote: > >> Damien Hedde writes: > >> > >> > The biggest difference is the fw_cfg option I think: it is related > >> > with the rom_s

Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-25 Thread Damien Hedde
On 11/24/21 15:51, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Nov 24, 2021 at 02:50:11PM +0100, Markus Armbruster wrote: Damien Hedde writes: The biggest difference is the fw_cfg option I think: it is related with the rom_set_order_override()/rom_reset_order_override()

Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-24 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Nov 24, 2021 at 02:50:11PM +0100, Markus Armbruster wrote: >> Damien Hedde writes: >> >> > The biggest difference is the fw_cfg option I think: it is related >> > with the rom_set_order_override()/rom_reset_order_override() (line 17 >> > and 25). There is al

Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-24 Thread Daniel P . Berrangé
On Wed, Nov 24, 2021 at 02:50:11PM +0100, Markus Armbruster wrote: > Damien Hedde writes: > > > The biggest difference is the fw_cfg option I think: it is related > > with the rom_set_order_override()/rom_reset_order_override() (line 17 > > and 25). There is also the usb devices parts in between.

Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-24 Thread Markus Armbruster
Damien Hedde writes: > On 11/20/21 10:00, Markus Armbruster wrote: >> Damien Hedde writes: >> >>> Hi all, >>> >>> This series adds support for cold-plugging devices using QMP >>> commands. It is a step towards machine configuration using QMP, but >>> it does not allow the user to add more devic

Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-23 Thread Damien Hedde
On 11/20/21 10:00, Markus Armbruster wrote: Damien Hedde writes: Hi all, This series adds support for cold-plugging devices using QMP commands. It is a step towards machine configuration using QMP, but it does not allow the user to add more devices than he could do with the CLI options bef

Re: [RFC PATCH v3 0/5] QMP support for cold-plugging devices

2021-11-20 Thread Markus Armbruster
Damien Hedde writes: > Hi all, > > This series adds support for cold-plugging devices using QMP > commands. It is a step towards machine configuration using QMP, but > it does not allow the user to add more devices than he could do with > the CLI options before. > > Right now we can add a device