Re: [RFC PATCH v2 5/7] target/ppc: Implemented xvf16ger*

2022-05-10 Thread Lucas Mateus Martins Araujo e Castro
On 08/05/2022 01:24, Richard Henderson wrote: On 5/6/22 07:18, Lucas Mateus Castro(alqotel) wrote: +static inline float32 float32_neg(float32 a) +{ +    if (((a & 0x7f80) == 0x7f80) && (a & 0x007f)) { +    return a; +    } else { +    return float32_chs(a); +    } +} This

Re: [RFC PATCH v2 5/7] target/ppc: Implemented xvf16ger*

2022-05-07 Thread Richard Henderson
On 5/6/22 07:18, Lucas Mateus Castro(alqotel) wrote: +static inline float32 float32_neg(float32 a) +{ +if (((a & 0x7f80) == 0x7f80) && (a & 0x007f)) { +return a; +} else { +return float32_chs(a); +} +} This is wrong -- even NaNs get their signs changed. N