Re: [RFC PATCH 2/5] system/memory: support unaligned access

2025-01-14 Thread Tomoyuki HIROSE
On 2025/01/11 0:08, Peter Xu wrote: On Fri, Jan 10, 2025 at 07:11:27PM +0900, Tomoyuki HIROSE wrote: MR implementation to be safe when unaligned accessing (current xHCI implementation does not handle unaligned accesses but the spec allows unaligned accesses). In addition, maybe it would be bett

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2025-01-10 Thread Peter Xu
On Fri, Jan 10, 2025 at 07:11:27PM +0900, Tomoyuki HIROSE wrote: > > > MR implementation to be safe when unaligned accessing (current xHCI > > > implementation does not handle unaligned accesses but the spec allows > > > unaligned accesses). > > > > > > In addition, maybe it would be better to doc

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2025-01-10 Thread Tomoyuki HIROSE
On 2025/01/09 1:50, Peter Xu wrote: Hi, Tomoyuki, On Wed, Jan 08, 2025 at 11:58:10AM +0900, Tomoyuki HIROSE wrote: Happy new year, Peter. I had another job and was late in replying to your email, sorry. Happy new year. That's fine. :) [...] So.. it turns out we shouldn't drop impl.unalig

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2025-01-08 Thread Peter Xu
Hi, Tomoyuki, On Wed, Jan 08, 2025 at 11:58:10AM +0900, Tomoyuki HIROSE wrote: > Happy new year, Peter. > I had another job and was late in replying to your email, sorry. Happy new year. That's fine. :) [...] > > So.. it turns out we shouldn't drop impl.unaligned? Because above two > > seems

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2025-01-07 Thread Tomoyuki HIROSE
Happy new year, Peter. I had another job and was late in replying to your email, sorry. On 2024/12/13 0:46, Peter Xu wrote: On Thu, Dec 12, 2024 at 02:39:41PM +0900, Tomoyuki HIROSE wrote: On 2024/12/12 7:54, Peter Xu wrote: On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote: So

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-12 Thread Peter Xu
On Thu, Dec 12, 2024 at 02:39:41PM +0900, Tomoyuki HIROSE wrote: > On 2024/12/12 7:54, Peter Xu wrote: > > On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote: > > > Sorry for late reply. > > > > > > On 2024/12/07 1:42, Peter Xu wrote: > > > > On Fri, Dec 06, 2024 at 05:31:33PM +0900,

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-11 Thread Tomoyuki HIROSE
On 2024/12/12 7:54, Peter Xu wrote: On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote: Sorry for late reply. On 2024/12/07 1:42, Peter Xu wrote: On Fri, Dec 06, 2024 at 05:31:33PM +0900, Tomoyuki HIROSE wrote: In this email, I explain what this patch set will resolve and an over

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-11 Thread Peter Xu
On Wed, Dec 11, 2024 at 06:35:57PM +0900, Tomoyuki HIROSE wrote: > Sorry for late reply. > > On 2024/12/07 1:42, Peter Xu wrote: > > On Fri, Dec 06, 2024 at 05:31:33PM +0900, Tomoyuki HIROSE wrote: > > > In this email, I explain what this patch set will resolve and an > > > overview of this patch

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-11 Thread Peter Xu
On Wed, Dec 11, 2024 at 09:56:21AM +, Peter Maydell wrote: > On Fri, 6 Dec 2024 at 16:43, Peter Xu wrote: > > I assume it's about xhci_cap_ops then. If you agree we can also mention > > xhci_cap_ops when dscribing it, so readers can easily reference the MR > > attributes from the code alongsi

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-11 Thread Peter Maydell
On Fri, 6 Dec 2024 at 16:43, Peter Xu wrote: > I assume it's about xhci_cap_ops then. If you agree we can also mention > xhci_cap_ops when dscribing it, so readers can easily reference the MR > attributes from the code alongside with understanding the use case. > > Does it mean that it could also

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-11 Thread Tomoyuki HIROSE
Sorry for late reply. On 2024/12/07 1:42, Peter Xu wrote: On Fri, Dec 06, 2024 at 05:31:33PM +0900, Tomoyuki HIROSE wrote: In this email, I explain what this patch set will resolve and an overview of this patch set. I will respond to your specific code review comments in a separate email. Yes,

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-06 Thread Peter Xu
On Fri, Dec 06, 2024 at 05:31:33PM +0900, Tomoyuki HIROSE wrote: > In this email, I explain what this patch set will resolve and an > overview of this patch set. I will respond to your specific code > review comments in a separate email. Yes, that's OK. > > On 2024/12/03 6:23, Peter Xu wrote: >

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-06 Thread Tomoyuki HIROSE
In this email, I explain what this patch set will resolve and an overview of this patch set. I will respond to your specific code review comments in a separate email. On 2024/12/03 6:23, Peter Xu wrote: On Fri, Nov 08, 2024 at 12:29:46PM +0900, Tomoyuki HIROSE wrote: The previous code ignored '

Re: [RFC PATCH 2/5] system/memory: support unaligned access

2024-12-02 Thread Peter Xu
On Fri, Nov 08, 2024 at 12:29:46PM +0900, Tomoyuki HIROSE wrote: > The previous code ignored 'impl.unaligned' and handled unaligned > accesses as is. But this implementation could not emulate specific > registers of some devices that allow unaligned access such as xHCI > Host Controller Capability