Re: [RFC PATCH 1/3] target/openrisc: Add basic support for semihosting

2022-06-05 Thread Richard Henderson
On 6/4/22 17:57, Stafford Horne wrote: I am kind of leaning towards dropping the semi-hosting patches and only moving forward with the virt patches. The reason being that 1. we would not need to expand the architecture spec to support the qemu virt platform, and we would need to document the NOP

Re: [RFC PATCH 1/3] target/openrisc: Add basic support for semihosting

2022-06-04 Thread Stafford Horne
On Thu, Jun 02, 2022 at 08:39:21AM -0700, Richard Henderson wrote: > On 5/27/22 10:27, Stafford Horne wrote: > > +void do_or1k_semihosting(CPUOpenRISCState *env, uint32_t k); > ... > > +DEF_HELPER_FLAGS_2(nop, 0, void, env, i32) > > Just call the helper "semihosting" and be done with it. > And the

Re: [RFC PATCH 1/3] target/openrisc: Add basic support for semihosting

2022-06-02 Thread Richard Henderson
On 5/27/22 10:27, Stafford Horne wrote: +void do_or1k_semihosting(CPUOpenRISCState *env, uint32_t k); ... +DEF_HELPER_FLAGS_2(nop, 0, void, env, i32) Just call the helper "semihosting" and be done with it. And the helper wants an ifdef for system mode. @@ -10,6 +10,7 @@ openrisc_ss.add(file