Re: [RFC PATCH] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-20 Thread Mahmoud Mandour
On Mon, Jul 19, 2021, 14:37 Alex Bennée wrote: > In user-mode emulation there is a small race between preexit_cleanup > and exit_group() which means we may end up calling instrumented > instructions before the kernel reaps child threads. To solve this we > implement a new helper which ensures the

Re: [RFC PATCH] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-19 Thread Warner Losh
On Mon, Jul 19, 2021, 1:22 PM Alex Bennée wrote: > > Warner Losh writes: > > > On Mon, Jul 19, 2021, 7:57 AM Alex Bennée > wrote: > > > > Alex Bennée writes: > > > > > In user-mode emulation there is a small race between preexit_cleanup > > > and exit_group() which means we may end up calli

Re: [RFC PATCH] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-19 Thread Alex Bennée
Warner Losh writes: > On Mon, Jul 19, 2021, 7:57 AM Alex Bennée wrote: > > Alex Bennée writes: > > > In user-mode emulation there is a small race between preexit_cleanup > > and exit_group() which means we may end up calling instrumented > > instructions before the kernel reaps child thre

Re: [RFC PATCH] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-19 Thread Warner Losh
On Mon, Jul 19, 2021, 7:57 AM Alex Bennée wrote: > > Alex Bennée writes: > > > In user-mode emulation there is a small race between preexit_cleanup > > and exit_group() which means we may end up calling instrumented > > instructions before the kernel reaps child threads. To solve this we > > imp

Re: [RFC PATCH] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-19 Thread Alex Bennée
Alex Bennée writes: > In user-mode emulation there is a small race between preexit_cleanup > and exit_group() which means we may end up calling instrumented > instructions before the kernel reaps child threads. To solve this we > implement a new helper which ensures the callbacks are flushed al