Re: [Qemu-devel] subpages with memory region aliases

2012-02-09 Thread Avi Kivity
On 02/09/2012 04:23 PM, Jan Kiszka wrote: > On 2012-02-09 10:32, Avi Kivity wrote: > > On 02/09/2012 10:35 AM, Jan Kiszka wrote: > >> Avi, > >> > >> Before I forget: > >> > >> On 2012-02-05 13:39, Jan Kiszka wrote: > >>> +static void vapic_map_rom_writable(VAPICROMState *s) > >>> +{ > >>> +targ

Re: [Qemu-devel] subpages with memory region aliases

2012-02-09 Thread Jan Kiszka
On 2012-02-09 10:32, Avi Kivity wrote: > On 02/09/2012 10:35 AM, Jan Kiszka wrote: >> Avi, >> >> Before I forget: >> >> On 2012-02-05 13:39, Jan Kiszka wrote: >>> +static void vapic_map_rom_writable(VAPICROMState *s) >>> +{ >>> +target_phys_addr_t rom_paddr = s->rom_state_paddr & ROM_BLOCK_MASK

Re: [Qemu-devel] subpages with memory region aliases

2012-02-09 Thread Avi Kivity
On 02/09/2012 10:35 AM, Jan Kiszka wrote: > Avi, > > Before I forget: > > On 2012-02-05 13:39, Jan Kiszka wrote: > > +static void vapic_map_rom_writable(VAPICROMState *s) > > +{ > > +target_phys_addr_t rom_paddr = s->rom_state_paddr & ROM_BLOCK_MASK; > > +MemoryRegionSection section; > > +