Re: [Qemu-devel] qemu elf_ops.h

2007-09-24 Thread Fabrice Bellard
Try to avoid using target_phys_addr_t at this place as I don't want this code to be CPU dependent (think of a machine having several different CPUs !). Regards, Fabrice. Blue Swirl wrote: CVSROOT:/cvsroot/qemu Module name:qemu Changes by: Blue Swirl 07/09/24 18:41:27 Mod

Re: [Qemu-devel] qemu elf_ops.h loader.c hw/mips_r4k.c target-ar...

2006-12-23 Thread Thiemo Seufer
Fabrice Bellard wrote: > Your change in elf_ops.h regarding the labels fail1 and fail2 is not > necessary: qemu_free(NULL) is perfectly valid and there are many pieces > of code relying on it. Please revert. Changed accordingly. Thiemo ___ Qemu-dev

Re: [Qemu-devel] qemu elf_ops.h loader.c hw/mips_r4k.c target-ar...

2006-12-23 Thread Fabrice Bellard
Your change in elf_ops.h regarding the labels fail1 and fail2 is not necessary: qemu_free(NULL) is perfectly valid and there are many pieces of code relying on it. Please revert. Regards, Fabrice. Thiemo Seufer wrote: CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo