Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-07 Thread Peter Lieven
On 06.03.2014 15:19, Liguori, Anthony wrote: We can check the moderation queue although it's usually empty. Savannah has a pretty aggressive spam filter and mail delivery isn't always reliable. I think I got it. I accidently had a typo (missing space) in the git send-email command which left

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Peter Lieven
Am 06.03.2014 11:41, schrieb Stefan Hajnoczi: > On Wed, Mar 05, 2014 at 07:09:13PM +0100, Peter Lieven wrote: >> Am 05.03.2014 18:38, schrieb Marcus: >>> On Wed, Mar 5, 2014 at 8:53 AM, Peter Lieven wrote: So you can confirm my oberservations and would be happy if this behaviour could be

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Peter Lieven
Hi Anthony, Am 06.03.2014 15:19, schrieb Liguori, Anthony: > We can check the moderation queue although it's usually empty. Savannah has > a pretty aggressive spam filter and mail delivery isn't always reliable. It would be good to know why these mails got lost. It seems to have happened someti

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Paolo Bonzini
Il 06/03/2014 11:29, Stefan Hajnoczi ha scritto: On Wed, Mar 05, 2014 at 03:44:17PM +0100, Peter Lieven wrote: [PATCH] block: introduce BDRV_O_SEQUENTIAL It hasn't shown up on the mailing list yet. I received it privately because I am CCed but it needs to be on the list in order to get review

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 07:09:13PM +0100, Peter Lieven wrote: > Am 05.03.2014 18:38, schrieb Marcus: > > On Wed, Mar 5, 2014 at 8:53 AM, Peter Lieven wrote: > >> So you can confirm my oberservations and would be happy if > >> this behaviour could be toggled with a cmdline switch? > > Yes, I've see

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 03:44:17PM +0100, Peter Lieven wrote: > [PATCH] block: introduce BDRV_O_SEQUENTIAL It hasn't shown up on the mailing list yet. I received it privately because I am CCed but it needs to be on the list in order to get review and be merged. Anthony: how can Peter troubleshoo

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-05 Thread Peter Lieven
Am 05.03.2014 18:38, schrieb Marcus: > On Wed, Mar 5, 2014 at 8:53 AM, Peter Lieven wrote: >> Am 05.03.2014 16:20, schrieb Marcus: >>> I think this is a more generic sysadmin problem. I've seen the same >>> thing in the past with simply snapshotting a logical volume or zfs >>> zvol and copying it

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-05 Thread Marcus
On Wed, Mar 5, 2014 at 8:53 AM, Peter Lieven wrote: > Am 05.03.2014 16:20, schrieb Marcus: >> I think this is a more generic sysadmin problem. I've seen the same >> thing in the past with simply snapshotting a logical volume or zfs >> zvol and copying it off somewhere. Page cache bloats, the syst

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-05 Thread Peter Lieven
Am 05.03.2014 16:20, schrieb Marcus: > I think this is a more generic sysadmin problem. I've seen the same > thing in the past with simply snapshotting a logical volume or zfs > zvol and copying it off somewhere. Page cache bloats, the system > starts swapping. To avoid it, we wrote a small C prog

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-05 Thread Marcus
I think this is a more generic sysadmin problem. I've seen the same thing in the past with simply snapshotting a logical volume or zfs zvol and copying it off somewhere. Page cache bloats, the system starts swapping. To avoid it, we wrote a small C program that calls FADV_DONTNEED on a file, and f

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-05 Thread Peter Lieven
Am 04.03.2014 10:24, schrieb Stefan Hajnoczi: > On Mon, Mar 03, 2014 at 01:20:21PM +0100, Peter Lieven wrote: >> On 03.03.2014 13:03, Stefan Hajnoczi wrote: >>> So what is the actual performance problem you are trying to solve and >>> what benchmark output are you getting when you compare with >>>

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-04 Thread Stefan Hajnoczi
On Mon, Mar 03, 2014 at 01:20:21PM +0100, Peter Lieven wrote: > On 03.03.2014 13:03, Stefan Hajnoczi wrote: > >So what is the actual performance problem you are trying to solve and > >what benchmark output are you getting when you compare with > >FADV_DONTNEED against without FADV_DONTNEED? > I fou

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-03 Thread Peter Lieven
On 03.03.2014 13:59, Paolo Bonzini wrote: Il 03/03/2014 12:20, Peter Lieven ha scritto: This #ifdef should be in the raw-posix driver. Please try to keep the qemu interface backend agnostic and leave POSIX_FADV_DONTNEED and friends as an implementation detail of block drivers. I had the same

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 12:20, Peter Lieven ha scritto: This #ifdef should be in the raw-posix driver. Please try to keep the qemu interface backend agnostic and leave POSIX_FADV_DONTNEED and friends as an implementation detail of block drivers. I had the same idee, but as far as I see the callback to t

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-03 Thread Peter Lieven
On 03.03.2014 13:03, Stefan Hajnoczi wrote: On Fri, Feb 28, 2014 at 03:35:05PM +0100, Peter Lieven wrote: On 27.02.2014 09:57, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: On 26.02.2014 16:41, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 11:14:04AM +0

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-03 Thread Stefan Hajnoczi
On Fri, Feb 28, 2014 at 03:35:05PM +0100, Peter Lieven wrote: > On 27.02.2014 09:57, Stefan Hajnoczi wrote: > >On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: > >>On 26.02.2014 16:41, Stefan Hajnoczi wrote: > >>>On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > I was

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-03 Thread Peter Lieven
On 03.03.2014 11:38, Kevin Wolf wrote: Am 28.02.2014 um 15:35 hat Peter Lieven geschrieben: On 27.02.2014 09:57, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: On 26.02.2014 16:41, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lie

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-03 Thread Kevin Wolf
Am 27.02.2014 um 17:12 hat Peter Lieven geschrieben: > Am 27.02.2014 12:07, schrieb Kevin Wolf: > > Am 27.02.2014 um 02:10 hat Fam Zheng geschrieben: > >> On Wed, 02/26 16:41, Stefan Hajnoczi wrote: > >>> On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > I was wondering if it wou

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-03 Thread Kevin Wolf
Am 28.02.2014 um 15:35 hat Peter Lieven geschrieben: > On 27.02.2014 09:57, Stefan Hajnoczi wrote: > >On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: > >>On 26.02.2014 16:41, Stefan Hajnoczi wrote: > >>>On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > I was wonderin

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-28 Thread Peter Lieven
On 27.02.2014 09:57, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: On 26.02.2014 16:41, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the sourc

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-27 Thread Peter Lieven
Am 27.02.2014 12:07, schrieb Kevin Wolf: > Am 27.02.2014 um 02:10 hat Fam Zheng geschrieben: >> On Wed, 02/26 16:41, Stefan Hajnoczi wrote: >>> On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the source

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-27 Thread Kevin Wolf
Am 27.02.2014 um 02:10 hat Fam Zheng geschrieben: > On Wed, 02/26 16:41, Stefan Hajnoczi wrote: > > On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > > > I was wondering if it would be a good idea to set the O_DIRECT mode for > > > the source > > > files of a qemu-img convert process

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-27 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: > On 26.02.2014 16:41, Stefan Hajnoczi wrote: > >On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > >>I was wondering if it would be a good idea to set the O_DIRECT mode for the > >>source > >>files of a qemu-img convert pr

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Fam Zheng
On Wed, 02/26 16:41, Stefan Hajnoczi wrote: > On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > > I was wondering if it would be a good idea to set the O_DIRECT mode for the > > source > > files of a qemu-img convert process if the source is a host_device? > > > > Currently the back

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Peter Lieven
On 26.02.2014 16:41, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the source files of a qemu-img convert process if the source is a host_device? Currently the backup of a host device

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Eric Blake
On 02/26/2014 08:41 AM, Stefan Hajnoczi wrote: > On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: >> I was wondering if it would be a good idea to set the O_DIRECT mode for the >> source >> files of a qemu-img convert process if the source is a host_device? >> >> Currently the backup

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > I was wondering if it would be a good idea to set the O_DIRECT mode for the > source > files of a qemu-img convert process if the source is a host_device? > > Currently the backup of a host device is polluting the page cache. Points