Re: [Qemu-devel] help parsing qemu options

2015-03-11 Thread Kevin Wolf
Am 11.03.2015 um 13:53 hat Gabriel L. Somlo geschrieben: > On Wed, Mar 11, 2015 at 08:40:46AM -0400, Gabriel L. Somlo wrote: > > On Wed, Mar 11, 2015 at 12:59:40PM +0100, Kevin Wolf wrote: > > > > > > def_value_str exists in the current codebase, and it seems to take > > > precedence when a differ

Re: [Qemu-devel] help parsing qemu options

2015-03-11 Thread Gabriel L. Somlo
On Wed, Mar 11, 2015 at 08:40:46AM -0400, Gabriel L. Somlo wrote: > On Wed, Mar 11, 2015 at 12:59:40PM +0100, Kevin Wolf wrote: > > > > def_value_str exists in the current codebase, and it seems to take > > precedence when a different default is specified by the caller. > > So I've now added .def

Re: [Qemu-devel] help parsing qemu options

2015-03-11 Thread Gabriel L. Somlo
On Wed, Mar 11, 2015 at 12:59:40PM +0100, Kevin Wolf wrote: > > def_value_str exists in the current codebase, and it seems to take > precedence when a different default is specified by the caller. So I've now added .def_value_str fields: static QemuOptsList qemu_foo_opts = { .name = "foo",

Re: [Qemu-devel] help parsing qemu options

2015-03-11 Thread Kevin Wolf
Am 11.03.2015 um 08:52 hat Markus Armbruster geschrieben: > "Gabriel L. Somlo" writes: > > > On Tue, Mar 10, 2015 at 09:40:09AM +0100, Markus Armbruster wrote: > >> "Gabriel L. Somlo" writes: > >> > Assuming the above is correct (and that the appropriate glue is added > >> > to qemu-options.hx t

Re: [Qemu-devel] help parsing qemu options

2015-03-11 Thread Markus Armbruster
"Gabriel L. Somlo" writes: > On Tue, Mar 10, 2015 at 09:40:09AM +0100, Markus Armbruster wrote: >> "Gabriel L. Somlo" writes: >> > Assuming the above is correct (and that the appropriate glue is added >> > to qemu-options.hx to tie "-foo name=abc,file=xyz" to QEMU_OPTION_foo), >> > I'm wondering

Re: [Qemu-devel] help parsing qemu options

2015-03-10 Thread Gabriel L. Somlo
On Tue, Mar 10, 2015 at 09:40:09AM +0100, Markus Armbruster wrote: > "Gabriel L. Somlo" writes: > > Assuming the above is correct (and that the appropriate glue is added > > to qemu-options.hx to tie "-foo name=abc,file=xyz" to QEMU_OPTION_foo), > > I'm wondering about preventing "name" and "file"

Re: [Qemu-devel] help parsing qemu options

2015-03-10 Thread Markus Armbruster
"Gabriel L. Somlo" writes: > Hi, > > Assuming I'm trying to add a new command line option to qemu in vl.c: > > ... > > static QemuOptsList qemu_foo_opts = { > .name = "foo", > .implied_opt_name = "name", > .head = QTAILQ_HEAD_INITIALIZER(qemu_foo_opts.head), > .desc = { >