Re: [Qemu-devel] blockdev-commit design

2017-09-27 Thread Max Reitz
On 2017-09-26 19:59, Kevin Wolf wrote: [...] > * The old block-commit command decides between an "actual" commit job > and the mirror-based active commit based on whether top is the > active layer. > > We don't get an option for the active layer any more now, so this > isn't ho

Re: [Qemu-devel] blockdev-commit design

2017-09-26 Thread Kevin Wolf
Am 26.09.2017 um 20:29 hat Eric Blake geschrieben: > On 09/26/2017 12:59 PM, Kevin Wolf wrote: > > This was the easy part. Then I started looking at the code and found a > > few a bit more interesting questions: > > > > * The old block-commit command decides between an "actual" commit job > >

Re: [Qemu-devel] blockdev-commit design

2017-09-26 Thread Eric Blake
On 09/26/2017 12:59 PM, Kevin Wolf wrote: > Hi, > > as the next step after my commit block job fixes, I'm trying to > implement a new, clean version of the QMP command, which I'm calling > blockdev-commit for consistency with all the other "modern" QMP > commands. > > I'll start with the schema t