Re: [Qemu-devel] aspeed qemu question

2019-05-23 Thread Wim Vervoorn
Hello Cédric, How stupid of me. I overlooked that the SPI is for the host flash device. The remainder of the solution was clear and understood. Best regards and thanks for the quick response, Wim -Original Message- From: Cédric Le Goater [mailto:c...@kaod.org] Sent: Thursday, May 23,

Re: [Qemu-devel] aspeed qemu question

2019-05-23 Thread Cédric Le Goater
On 5/23/19 12:05 PM, Wim Vervoorn wrote: > Hello Cédric, > > I have another question regarding the ASPEED Qemu support. This is regarding > the SPI support. > > I noticed that in general the fmc_model and the spi_model for the flash device > are different even though there is only one flash devi

Re: [Qemu-devel] aspeed qemu question

2019-05-23 Thread Wim Vervoorn
Hello Cédric, I have another question regarding the ASPEED Qemu support. This is regarding the SPI support. I noticed that in general the fmc_model and the spi_model for the flash device are different even though there is only one flash device connected. I would expect that in this case the mo

Re: [Qemu-devel] aspeed qemu question

2019-05-20 Thread Cédric Le Goater
Hello Wim, On 5/20/19 9:42 AM, Wim Vervoorn wrote: > Hello Cédric, > > It was not yet my intention to have this patch included in the qemu repo so I > didn't pay attention to checking the indentation etc. So I misunderstood your > suggestion. I am sorry about that. > > I will address your rema

Re: [Qemu-devel] aspeed qemu question

2019-05-20 Thread Wim Vervoorn
Hello Cédric, It was not yet my intention to have this patch included in the qemu repo so I didn't pay attention to checking the indentation etc. So I misunderstood your suggestion. I am sorry about that. I will address your remarks in a new patch. Besides this I have another question. First

Re: [Qemu-devel] aspeed qemu question

2019-05-17 Thread Cédric Le Goater
Hello Win, On 5/17/19 9:46 AM, Wim Vervoorn wrote: > Hello Cedríc, > > Thanks for your response. I created and attached the patch. You are right the > code snipped turns out unreadable. You should try to send the patch directly and not attached. Checkout the git send-email commands for it. See

Re: [Qemu-devel] aspeed qemu question

2019-05-17 Thread Wim Vervoorn
Hello Cedríc, Thanks for your response. I created and attached the patch. You are right the code snipped turns out unreadable. In the patch I enable the MAC's depending on the value in hwstrap1 just as in the real hardware. In the Palmetto both nics will be enabled (just as in the real palmett