Re: [Qemu-devel] Wshadow in qemu/linux-user/syscall.c

2019-04-08 Thread 马艺诚
-block"; Subject: Re: [Qemu-devel] Wshadow in qemu/linux-user/syscall.c Am 08.04.2019 um 10:40 hat ghorges geschrieben: > --- > linux-user/syscall.c | 66 ++-- > 1 file changed, 33 insertions(+), 33 deletions(-) Thomas already gave you some hin

Re: [Qemu-devel] Wshadow in qemu/linux-user/syscall.c

2019-04-08 Thread Kevin Wolf
Am 08.04.2019 um 10:40 hat ghorges geschrieben: > --- > linux-user/syscall.c | 66 ++-- > 1 file changed, 33 insertions(+), 33 deletions(-) Thomas already gave you some hints what to improve. I'd just like to add that you shouldn't send the email to the qem

Re: [Qemu-devel] Wshadow in qemu/linux-user/syscall.c

2019-04-08 Thread Thomas Huth
Hi, thanks for your patch! But please add a short patch description (beside the subject), e.g. "Change the name of some variables so that the code can be compiled with -Wshadow, too". And you've got to put a "Signed-off-by" line at the end of the patch description, too. See this URL for detail

Re: [Qemu-devel] Wshadow in qemu/linux-user/syscall.c

2019-04-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190408084056.26212-1-ghor...@xiyoulinux.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190408084056.26212-1-ghor...@xiyoulinux.org Subject: [Qemu-devel] Wshadow in qemu/linux-user/sysc