Re: [Qemu-devel] Suspicious fall through in qemu_default_pixelformat()

2011-11-22 Thread Stefano Stabellini
On Tue, 22 Nov 2011, Markus Armbruster wrote: > Stefano Stabellini writes: > > > On Tue, 22 Nov 2011, Markus Armbruster wrote: > >> Case 24 falls through to case 32, which overwrites all of case 24's > >> work. Looks wrong. Git blames commit 0da2ea1b "fix endianness problem > >> sharing the vid

Re: [Qemu-devel] Suspicious fall through in qemu_default_pixelformat()

2011-11-22 Thread Markus Armbruster
Stefano Stabellini writes: > On Tue, 22 Nov 2011, Markus Armbruster wrote: >> Case 24 falls through to case 32, which overwrites all of case 24's >> work. Looks wrong. Git blames commit 0da2ea1b "fix endianness problem >> sharing the videoram buffer". >> >> Patching in a break is easy enough,

Re: [Qemu-devel] Suspicious fall through in qemu_default_pixelformat()

2011-11-22 Thread Stefano Stabellini
On Tue, 22 Nov 2011, Stefan Hajnoczi wrote: > On Tue, Nov 22, 2011 at 10:06 AM, Markus Armbruster wrote: > > Case 24 falls through to case 32, which overwrites all of case 24's > > work.  Looks wrong.  Git blames commit 0da2ea1b "fix endianness > > problem > > sharing the videoram buffer".

Re: [Qemu-devel] Suspicious fall through in qemu_default_pixelformat()

2011-11-22 Thread Stefano Stabellini
On Tue, 22 Nov 2011, Markus Armbruster wrote: > Case 24 falls through to case 32, which overwrites all of case 24's > work. Looks wrong. Git blames commit 0da2ea1b "fix endianness problem > sharing the videoram buffer". > > Patching in a break is easy enough, but since I don't actually > underst

Re: [Qemu-devel] Suspicious fall through in qemu_default_pixelformat()

2011-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2011 at 10:06 AM, Markus Armbruster wrote: > Case 24 falls through to case 32, which overwrites all of case 24's > work.  Looks wrong.  Git blames commit 0da2ea1b "fix endianness problem > sharing the videoram buffer". > > Patching in a break is easy enough, but since I don't actua