Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-28 Thread Blue Swirl
On Thu, Jan 28, 2010 at 8:33 PM, Loïc Minier wrote: > On Wed, Jan 27, 2010, Blue Swirl wrote: >> That must've been it. But I get this on Milax: > >  I didn't know about MilaX; I had a hard time getting gcc/binutils (or >  event git) to work along with working headers or base libs such as >  zlib.h

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-28 Thread Loïc Minier
On Wed, Jan 27, 2010, Blue Swirl wrote: > That must've been it. But I get this on Milax: I didn't know about MilaX; I had a hard time getting gcc/binutils (or event git) to work along with working headers or base libs such as zlib.h or unistd.h. Do you have any instructions on how to get these

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-27 Thread Blue Swirl
On Wed, Jan 27, 2010 at 12:41 PM, Loïc Minier wrote: > On Tue, Jan 26, 2010, Blue Swirl wrote: >> The patches didn't apply. Also please send only one patch per message, >> git am can't handle multiple patches. > >  They applied fine here, perhaps you didn't apply the sdl-config patch >  first?  I

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-27 Thread Loïc Minier
On Tue, Jan 26, 2010, Blue Swirl wrote: > The patches didn't apply. Also please send only one patch per message, > git am can't handle multiple patches. They applied fine here, perhaps you didn't apply the sdl-config patch first? I rebased them and resent them. -- Loïc Minier

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-26 Thread Blue Swirl
On Tue, Jan 26, 2010 at 6:47 PM, Loïc Minier wrote: > On Thu, Jan 21, 2010, Måns Rullgård wrote: >> I think that entire test is wrong, in fact.  It is perfectly possible >> for someone on Solaris to install a working "install" command in >> /usr/bin.  It is better, if possible, to test whatever "i

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-26 Thread Loïc Minier
On Thu, Jan 21, 2010, Måns Rullgård wrote: > I think that entire test is wrong, in fact. It is perfectly possible > for someone on Solaris to install a working "install" command in > /usr/bin. It is better, if possible, to test whatever "install" > command is in the path, and complain only if it

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-21 Thread Jamie Lokier
Måns Rullgård wrote: > If IFS is not set, the shell shall behave as if the value of IFS is > , , and > > If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe. > Likewise if you set the value first. Remove the colon. The above will wrongly change empty IFS, which is not the

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-21 Thread Loïc Minier
On Wed, Jan 20, 2010, Måns Rullgård wrote: > If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe. > Likewise if you set the value first. Ok; see attached patches -- Loïc Minier >From cccdcaeacc2214390c0c6c198ed875ac59d10669 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=2

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-20 Thread Loïc Minier
On Wed, Jan 20, 2010, Paolo Bonzini wrote: > > Are you saying that I can't backup/restore IFS without setting it > > first? > Yes, it affects the behavior of read for example: > $ echo a b c | (read a b c; echo $a; echo $b; echo $c) > a > b > c > $ IFS= > $ echo a b c | (read a b c; echo $a; echo

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-20 Thread Loïc Minier
On Wed, Jan 20, 2010, Loïc Minier wrote: > I'm attaching a new patch which changes the tests a bit; I would prefer > if someone with access to a Solaris build environment would do this > though. Sorry, there was a typo in the new patch, a test was reversed; updated patch attached. -- Loïc M

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-20 Thread Loïc Minier
On Wed, Jan 20, 2010, Juan Quintela wrote: > +prog_exist() { > +prog="$1" > +type $1 > /dev/null 2> /dev/null > +} You set prog but you use $1; also, it seems vars in functions should be prefixed with local_ in qemu's ./configure. I was told not to use a local var here though. > - if

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-20 Thread Loïc Minier
On Wed, Jan 20, 2010, Paolo Bonzini wrote: > On 01/20/2010 12:37 PM, Loïc Minier wrote: > >+# not found > >+IFS="$local_ifs" > If you do this, you should set IFS to space-tab-lf at the beginning of > the script, like this: > > IFS=" "" "" > " Are you saying that I can't backup/rest

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-20 Thread Loïc Minier
On Tue, Jan 19, 2010, Måns Rullgård wrote: [...] > Why the extra variable? Using $1 directly seems just as obvious to me. [...] I'm attaching an updated patch which doesn't use this variable. Should be applied after the sdl-config patch. > Is the full path of these tools really important? Do