Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-30 Thread Avi Kivity
On 05/12/2010 09:11 PM, Stefano Stabellini wrote: On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-28 Thread Michael Tokarev
12.05.2010 22:11, Stefano Stabellini wrote: On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all right, but it is not entirely cle

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-13 Thread Stefano Stabellini
On Thu, 13 May 2010, Michael Tokarev wrote: > Stefano Stabellini wrote: > [] > > diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c > > index 9f61a01..81c443b 100644 > > --- a/hw/cirrus_vga.c > > +++ b/hw/cirrus_vga.c > > The same as with previous patch: Yellow screen > (instead of crashing), and two

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-13 Thread Jamie Lokier
Stefano Stabellini wrote: > > I think we need to consider only dstpitch for a full invalidate. We > > might be copying an offscreen bitmap into the screen, and srcpitch is > > likely to be the bitmap width instead of the screen pitch. > > Agreed. Even when copying on-screen (or partially on-sc

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-13 Thread Michael Tokarev
Stefano Stabellini wrote: [] > diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c > index 9f61a01..81c443b 100644 > --- a/hw/cirrus_vga.c > +++ b/hw/cirrus_vga.c The same as with previous patch: Yellow screen (instead of crashing), and two lines on the stderr: BUG: kvm_dirty_pages_log_enable_slot: in

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-13 Thread Stefano Stabellini
On Thu, 13 May 2010, Avi Kivity wrote: > > /* extra x, y */ > > -sx = (src % ABS(s->cirrus_blt_srcpitch)) / depth; > > -sy = (src / ABS(s->cirrus_blt_srcpitch)); > > +sx = (src % line_offset) / depth; > > +sy = (src / line_offset); > > > > Does anything prevent the guest

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-13 Thread Avi Kivity
On 05/12/2010 09:11 PM, Stefano Stabellini wrote: On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Michael Tokarev
12.05.2010 22:11, Stefano Stabellini wrote: On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all right, but it is not entirely cle

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Stefano Stabellini
On Wed, 12 May 2010, Jamie Lokier wrote: > Stefano Stabellini wrote: > > On Wed, 12 May 2010, Avi Kivity wrote: > > > It's useful if you have a one-line horizontal pattern you want to > > > propagate all over. > > > > It might be useful all right, but it is not entirely clear what the > > hardwa

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-12 Thread Jamie Lokier
Stefano Stabellini wrote: > On Wed, 12 May 2010, Avi Kivity wrote: > > It's useful if you have a one-line horizontal pattern you want to > > propagate all over. > > It might be useful all right, but it is not entirely clear what the > hardware should do in this situation from the documentation w