Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-27 Thread Christian Borntraeger
On 09/27/2016 10:51 PM, Eduardo Habkost wrote: > On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote: >> On 09/22/2016 01:42 PM, Eduardo Habkost wrote: > [...] >>> In the case of the inject-nmi QMP command, I need to understand >>> what "default CPU" is supposed to mean in the inject-nmi

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-27 Thread Eduardo Habkost
On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote: > On 09/22/2016 01:42 PM, Eduardo Habkost wrote: [...] > > In the case of the inject-nmi QMP command, I need to understand > > what "default CPU" is supposed to mean in the inject-nmi > > documentation. Maybe it can be changed to use th

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-23 Thread Eduardo Habkost
On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote: > On 09/22/2016 01:42 PM, Eduardo Habkost wrote: [...] > > In the case of the inject-nmi QMP command, I need to understand > > what "default CPU" is supposed to mean in the inject-nmi > > documentation. Maybe it can be changed to use th

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-22 Thread Corey Minyard
On 09/22/2016 01:42 PM, Eduardo Habkost wrote: On Wed, Sep 21, 2016 at 03:38:25PM -0500, Corey Minyard wrote: On 09/21/2016 03:20 PM, Eduardo Habkost wrote: Hi, I was looking at the monitor code handling the "current CPU", and noticed that qmp_inject_nmi() looks suspicious: it is a QMP command

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-22 Thread Eduardo Habkost
On Wed, Sep 21, 2016 at 03:38:25PM -0500, Corey Minyard wrote: > On 09/21/2016 03:20 PM, Eduardo Habkost wrote: > > Hi, > > > > I was looking at the monitor code handling the "current CPU", and > > noticed that qmp_inject_nmi() looks suspicious: it is a QMP > > command, but uses monitor_get_cpu_in

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-21 Thread Corey Minyard
On 09/21/2016 03:20 PM, Eduardo Habkost wrote: Hi, I was looking at the monitor code handling the "current CPU", and noticed that qmp_inject_nmi() looks suspicious: it is a QMP command, but uses monitor_get_cpu_index(). In addition to the "inject-nmi" QMP command, qmp_inject_nmi() is used at: *