Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-22 Thread Supriya Kannery
On 11/22/2011 05:19 PM, Stefan Hajnoczi wrote: On Tue, Nov 22, 2011 at 11:16 AM, supriya kannery wrote: Kevin Wolf wrote: Am 22.11.2011 11:24, schrieb supriya kannery: How does VMDK implement its prepare/commit/abort? It needs to use the "public" bdrv_reopen_prepare() function on its im

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2011 at 11:16 AM, supriya kannery wrote: > Kevin Wolf wrote: >> >> Am 22.11.2011 11:24, schrieb supriya kannery: >> >>> >>> Stefan Hajnoczi wrote: >>> On Mon, Nov 21, 2011 at 12:13 PM, supriya kannery wrote: > > Stefan Hajnoczi wrote: > >> >

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-22 Thread supriya kannery
Kevin Wolf wrote: Am 22.11.2011 11:24, schrieb supriya kannery: Stefan Hajnoczi wrote: On Mon, Nov 21, 2011 at 12:13 PM, supriya kannery wrote: Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: @@ -708,17 +731,

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-22 Thread Kevin Wolf
Am 22.11.2011 11:24, schrieb supriya kannery: > Stefan Hajnoczi wrote: >> On Mon, Nov 21, 2011 at 12:13 PM, supriya kannery >> wrote: >> >>> Stefan Hajnoczi wrote: >>> On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: > @@ -708,17 +731,31 @@ int bdrv_

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-22 Thread supriya kannery
Stefan Hajnoczi wrote: On Mon, Nov 21, 2011 at 12:13 PM, supriya kannery wrote: Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: @@ -708,17 +731,31 @@ int bdrv_reopen(BlockDriverState *bs, in qerror_report(QERR_DATA_SYNC_FAILED, bs->device

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-21 Thread Stefan Hajnoczi
On Mon, Nov 21, 2011 at 12:13 PM, supriya kannery wrote: > Stefan Hajnoczi wrote: >> >> On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery >> wrote: >> >>> >>> @@ -708,17 +731,31 @@ int bdrv_reopen(BlockDriverState *bs, in >>>        qerror_report(QERR_DATA_SYNC_FAILED, bs->device_name); >>>      

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-21 Thread supriya kannery
Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: @@ -708,17 +731,31 @@ int bdrv_reopen(BlockDriverState *bs, in qerror_report(QERR_DATA_SYNC_FAILED, bs->device_name); return ret; } -open_flags = bs->open_flags; -bdrv_close(bs); -

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-17 Thread Stefan Hajnoczi
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: > @@ -708,17 +731,31 @@ int bdrv_reopen(BlockDriverState *bs, in >         qerror_report(QERR_DATA_SYNC_FAILED, bs->device_name); >         return ret; >     } > -    open_flags = bs->open_flags; > -    bdrv_close(bs); > > -    ret = bdrv_ope

Re: [Qemu-devel] [v9 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-17 Thread Luiz Capitulino
On Fri, 11 Nov 2011 12:18:18 +0530 Supriya Kannery wrote: > Struct BDRVReopenState along with three reopen related functions > introduced for handling reopen state of images safely. This can be > extended by each of the block drivers to reopen respective > image files. Shouldn't this patch come