Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-13 Thread Andreas Färber
Am 13.08.2012 12:27, schrieb Wenchao Xia: > 于 2012-8-10 18:48, Paolo Bonzini 写道: >> Il 09/08/2012 12:12, Wenchao Xia ha scritto: >>> +assert(0 == set_option_parameter_int(param, >>> +BLOCK_OPT_SIZE, o_cow->virt_size)); >> >> Assertions should not have side ef

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-13 Thread Wenchao Xia
于 2012-8-10 19:02, Kevin Wolf 写道: Am 09.08.2012 12:12, schrieb Wenchao Xia: This patch is the API design. Signed-off-by: Wenchao Xia --- libqblock.c | 670 +++ libqblock.h | 447 +++ 2 files ch

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-13 Thread Wenchao Xia
于 2012-8-10 18:48, Paolo Bonzini 写道: Il 09/08/2012 12:12, Wenchao Xia ha scritto: +/* copy information and take care the member difference in differect version. + Assuming all new member are added in the tail, struct size is the first + member, this is old to new version, src have its struct

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-10 Thread Kevin Wolf
Am 09.08.2012 12:12, schrieb Wenchao Xia: > This patch is the API design. > > Signed-off-by: Wenchao Xia > --- > libqblock.c | 670 > +++ > libqblock.h | 447 +++ > 2 files changed, 1117 insertions(+

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-10 Thread Paolo Bonzini
Il 09/08/2012 12:12, Wenchao Xia ha scritto: > +/* copy information and take care the member difference in differect version. > + Assuming all new member are added in the tail, struct size is the first > + member, this is old to new version, src have its struct_size set. */ > +static void qboc_

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-10 Thread Wenchao Xia
于 2012-8-10 1:36, Blue Swirl 写道: On Thu, Aug 9, 2012 at 10:12 AM, Wenchao Xia wrote: This patch is the API design. Signed-off-by: Wenchao Xia --- libqblock.c | 670 +++ libqblock.h | 447 +++

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-09 Thread Blue Swirl
On Thu, Aug 9, 2012 at 10:12 AM, Wenchao Xia wrote: > This patch is the API design. > > Signed-off-by: Wenchao Xia > --- > libqblock.c | 670 > +++ > libqblock.h | 447 +++ > 2 files changed, 1117 in