Re: [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects

2016-05-26 Thread Paolo Bonzini
On 26/05/2016 12:47, Bharata B Rao wrote: >>> > > } else if (cpu->stop || cpu->stopped) { >>> > > +if (cpu->unplug) { >> > >> > This "if" is unnecessary. next_cpu is not used anymore after the >> > "break", so the store is dead. > next_cpu is a global here. Won't tcg_exec_a

Re: [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects

2016-05-26 Thread Bharata B Rao
On Thu, May 26, 2016 at 12:19:05PM +0200, Paolo Bonzini wrote: > > > On 12/05/2016 05:48, Bharata B Rao wrote: > > @@ -1531,6 +1563,9 @@ static void tcg_exec_all(void) > > break; > > } > > } else if (cpu->stop || cpu->stopped) { > > +if (cpu->unp

Re: [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects

2016-05-26 Thread Paolo Bonzini
On 12/05/2016 05:48, Bharata B Rao wrote: > @@ -1531,6 +1563,9 @@ static void tcg_exec_all(void) > break; > } > } else if (cpu->stop || cpu->stopped) { > +if (cpu->unplug) { This "if" is unnecessary. next_cpu is not used anymore after the "brea