Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 04:52:05PM +0200, Andreas Färber wrote: > Hi Gerd, > > Am 24.07.2013 16:42, schrieb Gerd Hoffmann: > >>> This does not satisfy the "should use QOM properties" requirement that > >>> we discussed in the RFC thread. > >> > >> I don't know which part of the RFC thread still ap

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 04:42:08PM +0200, Gerd Hoffmann wrote: > Hi, > > >> This does not satisfy the "should use QOM properties" requirement that > >> we discussed in the RFC thread. > > > > I don't know which part of the RFC thread still applied and > > which doesn't: at that point you were r

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 17:09, Andreas Färber ha scritto: > Hi, > > Am 24.07.2013 17:04, schrieb Gerd Hoffmann: /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent for qdev_find_recursive would be handy, dunno whenever such a thing exists already, Andreas? >>> >>> Not sure

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Andreas Färber
Hi, Am 24.07.2013 17:04, schrieb Gerd Hoffmann: >>> /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent >>> for qdev_find_recursive would be handy, dunno whenever such a thing >>> exists already, Andreas? >> >> Not sure what's needed here? object_resolve_path() and >> object_fo

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Gerd Hoffmann
Hi, >> /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent >> for qdev_find_recursive would be handy, dunno whenever such a thing >> exists already, Andreas? > > Not sure what's needed here? object_resolve_path() and > object_foreach_child() come to mind... object_resolve_p

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Andreas Färber
Hi Gerd, Am 24.07.2013 16:42, schrieb Gerd Hoffmann: >>> This does not satisfy the "should use QOM properties" requirement that >>> we discussed in the RFC thread. >> >> I don't know which part of the RFC thread still applied and >> which doesn't: at that point you were rejecting the whole >> appr

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Gerd Hoffmann
Hi, >> This does not satisfy the "should use QOM properties" requirement that >> we discussed in the RFC thread. > > I don't know which part of the RFC thread still applied and > which doesn't: at that point you were rejecting the whole > approach. > > I found a mail where you said: > I'

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-08 Thread Michael S. Tsirkin
On Mon, Jul 08, 2013 at 02:10:03PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > This fills in guest info table with misc > > information of interest to the guest. > > Will be used by ACPI table generation code. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/acpi/

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-08 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > This fills in guest info table with misc > information of interest to the guest. > Will be used by ACPI table generation code. > > Signed-off-by: Michael S. Tsirkin > --- > hw/acpi/ich9.c | 7 ++- > hw/acpi/piix4.c| 44