Re: [Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev

2010-05-25 Thread Jan Kiszka
Paul Brook wrote: >> +static SysBusDeviceInfo hpet_device_info = { >> +.qdev.name= "hpet", >> +.qdev.size= sizeof(HPETState), >> +.qdev.no_user = 1, > > Why shouldn't the user create HPET devices? I thought you'd removed all the > global state. Long-term, there is no reason t

Re: [Qemu-devel] [RFT][PATCH 05/15] hpet: Convert to qdev

2010-05-25 Thread Paul Brook
> +static SysBusDeviceInfo hpet_device_info = { > +.qdev.name= "hpet", > +.qdev.size= sizeof(HPETState), > +.qdev.no_user = 1, Why shouldn't the user create HPET devices? I thought you'd removed all the global state. Paul