Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-07-16 Thread Shivaprasad G Bhat
Hi Fabiano, On 05/22/2019 09:37 PM, Fabiano Rosas wrote: Shivaprasad G Bhat writes: +/* Create DT entries for cold plugged NVDIMM devices */ +dimms = nvdimm_get_device_list(); +for (; dimms; dimms = dimms->next) { +NVDIMMDevice *nvdimm = dimms->data; + +spapr_popu

Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-22 Thread Fabiano Rosas
Shivaprasad G Bhat writes: > +/* Create DT entries for cold plugged NVDIMM devices */ > +dimms = nvdimm_get_device_list(); > +for (; dimms; dimms = dimms->next) { > +NVDIMMDevice *nvdimm = dimms->data; > + > +spapr_populate_nvdimm_node(fdt, offset, nvdimm); > +} >

Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-17 Thread Shivaprasad G Bhat
On 05/16/2019 07:02 AM, David Gibson wrote: On Wed, May 15, 2019 at 12:30:07PM +0530, Shivaprasad G Bhat wrote: Hi David, Thanks for the comments. Replies inline.. On 05/14/2019 07:52 AM, David Gibson wrote: On Mon, May 13, 2019 at 04:28:02AM -0500, Shivaprasad G Bhat wrote: Add support f

Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-15 Thread David Gibson
On Wed, May 15, 2019 at 12:30:07PM +0530, Shivaprasad G Bhat wrote: > Hi David, > > Thanks for the comments. Replies inline.. > > On 05/14/2019 07:52 AM, David Gibson wrote: > > On Mon, May 13, 2019 at 04:28:02AM -0500, Shivaprasad G Bhat wrote: > > > Add support for NVDIMM devices for sPAPR. Pig

Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-15 Thread Shivaprasad G Bhat
Hi David, Thanks for the comments. Replies inline.. On 05/14/2019 07:52 AM, David Gibson wrote: On Mon, May 13, 2019 at 04:28:02AM -0500, Shivaprasad G Bhat wrote: Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm device interface in QEMU to support virtual NVDIMM devices

Re: [Qemu-devel] [RFC v2 PATCH 2/3] spapr: Add NVDIMM device support

2019-05-13 Thread David Gibson
On Mon, May 13, 2019 at 04:28:02AM -0500, Shivaprasad G Bhat wrote: > Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm > device interface in QEMU to support virtual NVDIMM devices for Power (May have > to re-look at this later). Create the required DT entries for the > device