Re: [Qemu-devel] [RFC v2 06/38] plugin: add core code

2019-01-24 Thread Alex Bennée
Emilio G. Cota writes: > Some design requirements/goals: Also this commit breaks bisect-ability: 15:56:23 [alex@zen:~/l/q/qemu.git] (0138e1a5…)|BISECTING 2 + head -n 3 config.log # QEMU configure log Thu Jan 24 15:19:36 GMT 2019 # Configured with: './configure' '--disable-tools' '--di

Re: [Qemu-devel] [RFC v2 06/38] plugin: add core code

2018-12-10 Thread Emilio G. Cota
On Mon, Dec 10, 2018 at 14:37:25 +0300, Pavel Dovgalyuk wrote: > > From: Emilio G. Cota [mailto:c...@braap.org] (snip) > > +struct qemu_plugin_dyn_cb_arr { > > +struct qemu_plugin_dyn_cb *data; > > +size_t n; > > +size_t capacity; > > +}; > > + > > Why not list or something dynamic? P

Re: [Qemu-devel] [RFC v2 06/38] plugin: add core code

2018-12-10 Thread Pavel Dovgalyuk
> From: Emilio G. Cota [mailto:c...@braap.org] > +/* > + * A dynamic callback has an insertion point that is determined at run-time. > + * Usually the insertion point is somewhere in the code cache; think for > + * instance of a callback to be called upon the execution of a particular TB. > + */