Re: [Qemu-devel] [RFC v2 01/12] chardev: avoid crash if no associated address

2018-06-11 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 06:27:38PM +0200, Marc-André Lureau wrote: > A socket chardev may not have associated address (when adding client > fd manually for example). But on disconnect, updating socket filename > expects an address and may lead to this crash: > > Thread 1 "qemu-system-x86" receiv

Re: [Qemu-devel] [RFC v2 01/12] chardev: avoid crash if no associated address

2018-06-11 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:52:11AM -0300, Philippe Mathieu-Daudé wrote: > On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > > A socket chardev may not have associated address (when adding client > > fd manually for example). But on disconnect, updating socket filename > > expects an address and ma

Re: [Qemu-devel] [RFC v2 01/12] chardev: avoid crash if no associated address

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > A socket chardev may not have associated address (when adding client > fd manually for example). But on disconnect, updating socket filename > expects an address and may lead to this crash: > > Thread 1 "qemu-system-x86" received signal SIGSEGV,