Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-30 Thread Paolo Bonzini
Il 30/07/2014 10:24, Pavel Dovgaluk ha scritto: > Assertions is a good idea, we added such warning message to qemu_get_timedate > function > to be sure, that it is used correctly with replay. > > Another thing, that could help for making snapshots - find a way to load > replay structures > befor

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-30 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 28/07/2014 11:54, Pavel Dovgaluk ha scritto: > >>> > > +VMSTATE_TIMER_V(timer, RTL8139State, 5), > >> > > >> > timer need not be migrated, because it is reinstated by > >> > rtl8139_post_load. > >> >

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 11:54, Pavel Dovgaluk ha scritto: >>> > > +VMSTATE_TIMER_V(timer, RTL8139State, 5), >> > >> > timer need not be migrated, because it is reinstated by rtl8139_post_load. >> > > That's true for normal execution. > In replay execution mode post_load can be called before cac

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-28 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: > > This patch adds virtual clock-dependent timers to VMState to allow correct > > saving and restoring the state of RTL8139 network controller. > > > > Signed-off

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: > This patch adds virtual clock-dependent timers to VMState to allow correct > saving and restoring the state of RTL8139 network controller. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/net/rtl8139.c |5 - > 1 files changed, 4 insertions(