Re: [Qemu-devel] [RFC PATCH v2 1/3] separate thread for VM migration

2011-08-02 Thread Paolo Bonzini
On 08/01/2011 11:00 PM, Umesh Deshpande wrote: I kept this in migration.c to call qemu_savevm_state_begin. (The way it is done currently. i.e. to keep access to FdMigrationState in migration.c) Calling it from buffered_file.c would be inconsistent in that sense. or we will have to call it from

Re: [Qemu-devel] [RFC PATCH v2 1/3] separate thread for VM migration

2011-08-01 Thread Umesh Deshpande
On 08/01/2011 05:37 AM, Paolo Bonzini wrote: On 07/29/2011 10:57 PM, Umesh Deshpande wrote: This patch creates a separate thread for the guest migration on the source side. Signed-off-by: Umesh Deshpande Looks pretty good! One thing that shows, is that the interface separation between buff

Re: [Qemu-devel] [RFC PATCH v2 1/3] separate thread for VM migration

2011-08-01 Thread Paolo Bonzini
On 07/29/2011 10:57 PM, Umesh Deshpande wrote: This patch creates a separate thread for the guest migration on the source side. Signed-off-by: Umesh Deshpande Looks pretty good! One thing that shows, is that the interface separation between buffered_file.c is migration.c is pretty weird. Yo