Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-08 Thread Thomas Huth
On 08.11.2017 10:44, Gerd Hoffmann wrote: > On Wed, Nov 08, 2017 at 09:09:00AM +, Daniel P. Berrange wrote: >> On Tue, Nov 07, 2017 at 11:28:28PM -0300, Philippe Mathieu-Daudé wrote: >>> Deprecated since 2.9.0, guests should be able to use "pc" instead. >> >> Isn't isapc important to allow QEMU

Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-08 Thread Gerd Hoffmann
On Wed, Nov 08, 2017 at 09:09:00AM +, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 11:28:28PM -0300, Philippe Mathieu-Daudé wrote: > > Deprecated since 2.9.0, guests should be able to use "pc" instead. > > Isn't isapc important to allow QEMU to old operating systems that > predate the P

Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-08 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 11:28:28PM -0300, Philippe Mathieu-Daudé wrote: > Deprecated since 2.9.0, guests should be able to use "pc" instead. Isn't isapc important to allow QEMU to old operating systems that predate the PCI era. I do recall seeing some messages about specific cases where you cannot

Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-07 Thread Philippe Mathieu-Daudé
On 11/07/2017 11:28 PM, Philippe Mathieu-Daudé wrote: > Deprecated since 2.9.0, guests should be able to use "pc" instead. I forgot to add Paolo's comment: "but firmware code paths would be different, do we care?" > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc_piix.c | 1 + > 1