Re: [Qemu-devel] [RFC PATCH 16/21] trace: add infrastructure for building plugins

2018-10-15 Thread Alex Bennée
Richard Henderson writes: > On 10/5/18 8:49 AM, Alex Bennée wrote: >> +GLIB_CFLAGS = $(shell pkg-config --cflags glib-2.0) >> +CFLAGS = -I$(QEMU_SRC)/include/plugins $(GLIB_CFLAGS) -fno-PIE -fPIC -O3 -g >> +LDFLAGS = $(shell pkg-config --libs glib-2.0) -shared > > I'm not keen on defaulting to

Re: [Qemu-devel] [RFC PATCH 16/21] trace: add infrastructure for building plugins

2018-10-15 Thread Richard Henderson
On 10/5/18 8:49 AM, Alex Bennée wrote: > +GLIB_CFLAGS = $(shell pkg-config --cflags glib-2.0) > +CFLAGS = -I$(QEMU_SRC)/include/plugins $(GLIB_CFLAGS) -fno-PIE -fPIC -O3 -g > +LDFLAGS = $(shell pkg-config --libs glib-2.0) -shared I'm not keen on defaulting to -O3. I'd prefer if we passed up the fl