Re: [Qemu-devel] [RFC PATCH] softfloat: re-factor float to float conversions

2018-04-26 Thread Richard Henderson
On 04/26/2018 05:40 AM, Alex Bennée wrote: > +bool arm_hp = !ieee && (src_sz == 16); Surely you should be testing the destination format. The float16_unpack_canonical step should be handling the (non-)special cases to get into FloatParts. It would probably be better to invert the parameter to

Re: [Qemu-devel] [RFC PATCH] softfloat: re-factor float to float conversions

2018-04-26 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180426154035.16155-1-alex.ben...@linaro.org Subject: [Qemu-devel] [RFC PATCH] softfloat: re-factor float to float conversions === TEST SCRIPT BEGIN === #!/bin/bash BASE=b