Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code

2011-08-29 Thread Stefan Hajnoczi
On Wed, Jul 20, 2011 at 08:56:35PM +0200, Stefan Weil wrote: > cppcheck reports this error: > > qemu/hw/sh_intc.c:390: error: Possible null pointer dereference: > s - otherwise it is redundant to check if s is null at line 385 > > If s were NULL, the printf() statement would crash. > Setting bra

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code

2011-07-25 Thread Stefan Hajnoczi
On Wed, Jul 20, 2011 at 08:56:35PM +0200, Stefan Weil wrote: > cppcheck reports this error: > > qemu/hw/sh_intc.c:390: error: Possible null pointer dereference: > s - otherwise it is redundant to check if s is null at line 385 > > If s were NULL, the printf() statement would crash. > Setting bra