Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-13 Thread Alexander Graf
Am 13.09.2011 um 18:44 schrieb Scott Wood : > On 09/13/2011 08:08 AM, Alexander Graf wrote: >> Fabien Chouteau wrote: >>> static void booke_update_irq(CPUState *env) >>> { >>>ppc_set_irq(env, PPC_INTERRUPT_DECR, >>>(env->spr[SPR_BOOKE_TSR] & TSR_DIS >>> && e

Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-13 Thread Scott Wood
On 09/13/2011 08:08 AM, Alexander Graf wrote: > Fabien Chouteau wrote: >> static void booke_update_irq(CPUState *env) >> { >> ppc_set_irq(env, PPC_INTERRUPT_DECR, >> (env->spr[SPR_BOOKE_TSR] & TSR_DIS >> && env->spr[SPR_BOOKE_TCR] & TCR_DIE)); >> >> ppc_set_

Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-13 Thread Fabien Chouteau
On 13/09/2011 15:13, Alexander Graf wrote: > Alexander Graf wrote: >> Fabien Chouteau wrote: >> >>> On 12/09/2011 19:23, Scott Wood wrote: >>> >>> On 09/09/2011 09:58 AM, Alexander Graf wrote: > On 09.09.2011, at 16:22, Fabien Chouteau wrote: > >

Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-13 Thread Alexander Graf
Alexander Graf wrote: > Fabien Chouteau wrote: > >> On 12/09/2011 19:23, Scott Wood wrote: >> >> >>> On 09/09/2011 09:58 AM, Alexander Graf wrote: >>> >>> On 09.09.2011, at 16:22, Fabien Chouteau wrote: > if the interrupt is already set and

Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-13 Thread Alexander Graf
Fabien Chouteau wrote: > On 12/09/2011 19:23, Scott Wood wrote: > >> On 09/09/2011 09:58 AM, Alexander Graf wrote: >> >>> On 09.09.2011, at 16:22, Fabien Chouteau wrote: >>> if the interrupt is already set and you clear TCR.DIE, the interrupt has to remain set. The only way

Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-13 Thread Fabien Chouteau
On 12/09/2011 19:23, Scott Wood wrote: > On 09/09/2011 09:58 AM, Alexander Graf wrote: >> On 09.09.2011, at 16:22, Fabien Chouteau wrote: >>> if the interrupt is already set and you clear TCR.DIE, the interrupt has to >>> remain set. The only way to unset an interrupt is to clear the corresponding

Re: [Qemu-devel] [Qemu-ppc] [RESEND][PATCH] booke timers

2011-09-12 Thread Scott Wood
On 09/09/2011 09:58 AM, Alexander Graf wrote: > On 09.09.2011, at 16:22, Fabien Chouteau wrote: >> if the interrupt is already set and you clear TCR.DIE, the interrupt has to >> remain set. The only way to unset an interrupt is to clear the corresponding >> bit in TSR (currently in store_booke_tsr)