Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread David Gibson
On Fri, Aug 29, 2014 at 12:18:44AM +0200, Alexander Graf wrote: > > > On 28.08.14 20:20, Aravinda Prasad wrote: > > > > > > On Thursday 28 August 2014 04:10 PM, Alexander Graf wrote: > >> > >> > >> On 25.08.14 15:45, Aravinda Prasad wrote: > >>> Extend rtas-blob to accommodate error log. Error

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread David Gibson
On Fri, Aug 29, 2014 at 03:33:59AM +0200, Alexander Graf wrote: > > > > Am 29.08.2014 um 03:06 schrieb Benjamin Herrenschmidt : > > > >> On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote: > >> > >>> On 29.08.14 00:25, Benjamin Herrenschmidt wrote: > On Fri, 2014-08-29 at 00:18 +0200,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Benjamin Herrenschmidt
On Fri, 2014-08-29 at 03:33 +0200, Alexander Graf wrote: > I fail to see a problem, yeah :). Imagine the same thing on x86 with > its completely messed up instruction set. Would you still advocate for > in-qemu code or would you prefer to have a compiler between you and > the ugly opcodes? You mea

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
> Am 29.08.2014 um 03:06 schrieb Benjamin Herrenschmidt : > >> On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote: >> >>> On 29.08.14 00:25, Benjamin Herrenschmidt wrote: On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: I strongly disagree with David. Legally there is no

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Benjamin Herrenschmidt
On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote: > > On 29.08.14 00:25, Benjamin Herrenschmidt wrote: > > On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: > >> I strongly disagree with David. Legally there is no difference between a > >> .bin file that contains code and an array ma

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
On 29.08.14 00:25, Benjamin Herrenschmidt wrote: > On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: >> I strongly disagree with David. Legally there is no difference between a >> .bin file that contains code and an array made of instructions. And the >> more target code we can keep outsid

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Benjamin Herrenschmidt
On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote: > I strongly disagree with David. Legally there is no difference between a > .bin file that contains code and an array made of instructions. And the > more target code we can keep outside of QEMU the better. Ugh ... having a separate file wi

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
On 28.08.14 20:20, Aravinda Prasad wrote: > > > On Thursday 28 August 2014 04:10 PM, Alexander Graf wrote: >> >> >> On 25.08.14 15:45, Aravinda Prasad wrote: >>> Extend rtas-blob to accommodate error log. Error log >>> structure is saved in rtas space upon a machine check >>> exception. >>> >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Aravinda Prasad
On Thursday 28 August 2014 04:10 PM, Alexander Graf wrote: > > > On 25.08.14 15:45, Aravinda Prasad wrote: >> Extend rtas-blob to accommodate error log. Error log >> structure is saved in rtas space upon a machine check >> exception. >> >> Signed-off-by: Aravinda Prasad > > I can't say I'm a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
On 25.08.14 15:45, Aravinda Prasad wrote: > Extend rtas-blob to accommodate error log. Error log > structure is saved in rtas space upon a machine check > exception. > > Signed-off-by: Aravinda Prasad I can't say I'm a big fan of this patch. Can we somehow separate that NMI page from the RTAS