Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 06:12 PM, Eric Blake wrote: On 04/17/2013 05:07 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch - good progress. This file includ

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Eric Blake
On 04/17/2013 05:07 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Code that does need to be visible is kept > well contained inside this file and this is the only > new additional file to the entire patch - good > progress. > > This file includes the entire protocol and in

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 11:51 AM, Orit Wasserman wrote: On 04/18/2013 04:54 PM, Michael R. Hines wrote: On 04/18/2013 04:44 AM, Orit Wasserman wrote: Hi Michael, I don't see you addressed any of the comment I had in v3 (especially the error handling) please, fix those I did fix them, but not all of yo

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Orit Wasserman
On 04/18/2013 04:54 PM, Michael R. Hines wrote: > On 04/18/2013 04:44 AM, Orit Wasserman wrote: >> Hi Michael, >> >> I don't see you addressed any of the comment I had in v3 >> (especially the error handling) >> >> please, fix those > > I did fix them, but not all of your comments were correct, >

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Apr 18, 2013 at 10:45:19AM -0400, Michael R. Hines wrote: >> On 04/18/2013 09:32 AM, Michael S. Tsirkin wrote: >> >On Thu, Apr 18, 2013 at 10:14:27AM -0400, Michael R. Hines wrote: >> >>On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote: >> >>>On Thu, Apr 18,

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 10:45:19AM -0400, Michael R. Hines wrote: > On 04/18/2013 09:32 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 18, 2013 at 10:14:27AM -0400, Michael R. Hines wrote: > >>On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote: > >>>On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R.

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 09:32 AM, Michael S. Tsirkin wrote: On Thu, Apr 18, 2013 at 10:14:27AM -0400, Michael R. Hines wrote: On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote: On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote: On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote: The followi

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 10:14:27AM -0400, Michael R. Hines wrote: > On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote: > >>On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote: > >>>The following comment applies to all of this code: >

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 09:06 AM, Michael S. Tsirkin wrote: On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote: On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote: The following comment applies to all of this code: On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhi...@linux.vnet.ibm.com wrote:

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote: > On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote: > >The following comment applies to all of this code: > > > >On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhi...@linux.vnet.ibm.com wrote: > >>diff --git a/migration-rdma.c b/migratio

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote: The following comment applies to all of this code: On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhi...@linux.vnet.ibm.com wrote: diff --git a/migration-rdma.c b/migration-rdma.c new file mode 100644 index 000..1dff06f --- /dev/null +++ b/migra

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 03:55 AM, Paolo Bonzini wrote: The reason is that when using a management layer stderr will be logged but not printed to the operator's console. Instead, Errors are sent on the monitor connection. The management layer(s) then pick up the error and propagate it through the various

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 04:44 AM, Orit Wasserman wrote: Hi Michael, I don't see you addressed any of the comment I had in v3 (especially the error handling) please, fix those I did fix them, but not all of your comments were correct, because I was passing errp in many places were errp did not supposed

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael S. Tsirkin
The following comment applies to all of this code: On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhi...@linux.vnet.ibm.com wrote: > diff --git a/migration-rdma.c b/migration-rdma.c > new file mode 100644 > index 000..1dff06f > --- /dev/null > +++ b/migration-rdma.c > @@ -0,0 +1,2667 @@ > +/* > +

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 01:07, mrhi...@linux.vnet.ibm.com ha scritto: > +/* > + * Virtual address of the above structures used for transmitting > + * the RAMBlock descriptions at connection-time. > + * This structure is *not* transmitted. > + */ > +typedef struct RDMALocalBlocks { > +int num_blocks; > +