Re: [Qemu-devel] [PULL 45/74] spapr: do not use CPU_FOREACH_REVERSE

2018-08-24 Thread Emilio G. Cota
On Fri, Aug 24, 2018 at 16:20:24 +0100, Peter Maydell wrote: (snip) > Hi -- Coverity points out in CID1395181 that this introduces > a memory leak -- we allocate memory into the rev pointer > with g_renew(), but we never free it before leaving the function. Thanks for the heads up; fix forthcoming

Re: [Qemu-devel] [PULL 45/74] spapr: do not use CPU_FOREACH_REVERSE

2018-08-24 Thread Peter Maydell
On 21 August 2018 at 18:02, Paolo Bonzini wrote: > From: "Emilio G. Cota" > > This paves the way for implementing the CPU list with an RCU list, > which cannot be traversed in reverse order. > > Note that this is the only caller of CPU_FOREACH_REVERSE. > > Acked-by: David Gibson > Signed-off-by: