Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Markus Armbruster
Paolo Bonzini writes: > On 14/03/19 14:03, David Abdurachmanov wrote: >> Would it be enough to modify ./default-configs/riscv32-softmmu.mak by >> adding: >> >> CONFIG_PCIE_PORT=n > > The missing dependency is for any board that doesn't support MSI, not > just RISC-V. > > Note that technically wh

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Paolo Bonzini
On 14/03/19 14:03, David Abdurachmanov wrote: > Would it be enough to modify ./default-configs/riscv32-softmmu.mak by > adding: > > CONFIG_PCIE_PORT=n The missing dependency is for any board that doesn't support MSI, not just RISC-V. Note that technically what we do with msi_nonbroken makes no s

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Paolo Bonzini
On 14/03/19 14:00, Michael S. Tsirkin wrote: >> >> I haven't spent time digging further - and I'm not familiar enough >> with the QEMU build system anyway O:-) - but I wouldn't be surprised >> if the same happened for other architectures, too. > I'd say just disable it at build time by default. > H

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread David Abdurachmanov
On Thu, Mar 14, 2019 at 2:00 PM Michael S. Tsirkin wrote: > > On Thu, Mar 14, 2019 at 01:53:48PM +0100, Andrea Bolognani wrote: > > On Mon, 2019-03-04 at 19:19 +0100, Paolo Bonzini wrote: > > > Instead of including the same list of devices for each target, > > > set CONFIG_PCI to true, and make th

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 01:53:48PM +0100, Andrea Bolognani wrote: > On Mon, 2019-03-04 at 19:19 +0100, Paolo Bonzini wrote: > > Instead of including the same list of devices for each target, > > set CONFIG_PCI to true, and make the devices default to present > > whenever PCI is available. However,

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Paolo Bonzini
On 14/03/19 13:53, Andrea Bolognani wrote: > > $ ./riscv64-softmmu/qemu-system-riscv64 \ > -M virt \ > -device pcie-root-port > qemu-system-riscv64: -device pcie-root-port: MSI-X is not >supported by interrupt controller > > This is a limitation we have been aw

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Andrea Bolognani
On Mon, 2019-03-04 at 19:19 +0100, Paolo Bonzini wrote: > Instead of including the same list of devices for each target, > set CONFIG_PCI to true, and make the devices default to present > whenever PCI is available. However, s390x does not want all the > PCI devices, so there is a separate symbol