Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Paolo Bonzini
On 06/06/2016 17:02, Eduardo Habkost wrote: > On Mon, Jun 06, 2016 at 04:32:50PM +0200, Paolo Bonzini wrote: >> On 06/06/2016 16:15, Eduardo Habkost wrote: > No, the second time you'll get the expansion of > > DOCKER_SRC_COPY := docker-src.$(CUR_TIME) >>> And why it isn't enough to si

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 04:32:50PM +0200, Paolo Bonzini wrote: > On 06/06/2016 16:15, Eduardo Habkost wrote: > >> > No, the second time you'll get the expansion of > >> > > >> > DOCKER_SRC_COPY := docker-src.$(CUR_TIME) > > And why it isn't enough to simply write the above line in the > > Makefile

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Paolo Bonzini
On 06/06/2016 16:15, Eduardo Habkost wrote: >> > No, the second time you'll get the expansion of >> > >> > DOCKER_SRC_COPY := docker-src.$(CUR_TIME) > And why it isn't enough to simply write the above line in the > Makefile without any eval trick? Because 1) initially the idea was to delay the

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 04:01:53PM +0200, Paolo Bonzini wrote: > > > On 06/06/2016 14:50, Eduardo Habkost wrote: > > # Makes the definition constant after the first expansion > > DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := > > docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY) > > > > $(shell ec

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Paolo Bonzini
On 06/06/2016 14:50, Eduardo Habkost wrote: > # Makes the definition constant after the first expansion > DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := > docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY) > > $(shell echo DEBUG: src_copy: $(DOCKER_SRC_COPY) >&2) > > $(DOCKER_SRC_COPY): >

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 08:54:23AM -0300, Eduardo Habkost wrote: > On Mon, Jun 06, 2016 at 08:47:24AM -0300, Eduardo Habkost wrote: > > On Mon, Jun 06, 2016 at 02:58:24PM +0800, Fam Zheng wrote: > > > On Fri, 06/03 15:26, Eduardo Habkost wrote: > > > > On Fri, Jun 03, 2016 at 09:23:28AM +0800, Fam

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 08:47:24AM -0300, Eduardo Habkost wrote: > On Mon, Jun 06, 2016 at 02:58:24PM +0800, Fam Zheng wrote: > > On Fri, 06/03 15:26, Eduardo Habkost wrote: > > > On Fri, Jun 03, 2016 at 09:23:28AM +0800, Fam Zheng wrote: > > > > On Thu, 06/02 16:13, Eduardo Habkost wrote: > > > >

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 02:58:24PM +0800, Fam Zheng wrote: > On Fri, 06/03 15:26, Eduardo Habkost wrote: > > On Fri, Jun 03, 2016 at 09:23:28AM +0800, Fam Zheng wrote: > > > On Thu, 06/02 16:13, Eduardo Habkost wrote: > > > > On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: > > > > [...]

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Fam Zheng
On Fri, 06/03 15:26, Eduardo Habkost wrote: > On Fri, Jun 03, 2016 at 09:23:28AM +0800, Fam Zheng wrote: > > On Thu, 06/02 16:13, Eduardo Habkost wrote: > > > On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: > > > [...] > > > > + > > > > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.)

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-03 Thread Eduardo Habkost
On Fri, Jun 03, 2016 at 09:23:28AM +0800, Fam Zheng wrote: > On Thu, 06/02 16:13, Eduardo Habkost wrote: > > On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: > > [...] > > > + > > > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.) > > > +# Makes the definition constant after the first e

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-03 Thread Eduardo Habkost
On Fri, Jun 03, 2016 at 09:23:28AM +0800, Fam Zheng wrote: > On Thu, 06/02 16:13, Eduardo Habkost wrote: > > On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: > > [...] > > > + > > > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.) > > > +# Makes the definition constant after the first e

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-02 Thread Fam Zheng
On Thu, 06/02 16:13, Eduardo Habkost wrote: > On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: > [...] > > + > > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.) > > +# Makes the definition constant after the first expansion > > +DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := > > docker-s

Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-02 Thread Eduardo Habkost
On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: [...] > + > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.) > +# Makes the definition constant after the first expansion > +DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := > docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY) > + > +$(DOCKER_SRC_COPY