Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 10:41, Gerd Hoffmann wrote: > Well, I can add -Wno-address-of-packed-member to the list of flags > configure tries to use with the compiler. That gets me past that > warning, but the build will stop on the next then. qemu simply doesn't > build warning-clean with clang ... Th

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-09 Thread Gerd Hoffmann
On Fri, Mar 09, 2018 at 10:48:13AM +0100, Thomas Huth wrote: > On 09.03.2018 10:44, Gerd Hoffmann wrote: > > On Fri, Mar 09, 2018 at 10:15:33AM +0100, Gerd Hoffmann wrote: > >> On Fri, Mar 09, 2018 at 09:46:44AM +0100, Thomas Huth wrote: > >>> On 09.03.2018 08:50, Gerd Hoffmann wrote: > Hi,

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-09 Thread Thomas Huth
On 09.03.2018 10:44, Gerd Hoffmann wrote: > On Fri, Mar 09, 2018 at 10:15:33AM +0100, Gerd Hoffmann wrote: >> On Fri, Mar 09, 2018 at 09:46:44AM +0100, Thomas Huth wrote: >>> On 09.03.2018 08:50, Gerd Hoffmann wrote: Hi, > Maybe I should move the code to a separate source file so it

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-09 Thread Gerd Hoffmann
On Fri, Mar 09, 2018 at 10:15:33AM +0100, Gerd Hoffmann wrote: > On Fri, Mar 09, 2018 at 09:46:44AM +0100, Thomas Huth wrote: > > On 09.03.2018 08:50, Gerd Hoffmann wrote: > > > Hi, > > > > > >> Maybe I should move the code to a separate source file so it can be > > >> built with different compi

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-09 Thread Gerd Hoffmann
On Fri, Mar 09, 2018 at 09:46:44AM +0100, Thomas Huth wrote: > On 09.03.2018 08:50, Gerd Hoffmann wrote: > > Hi, > > > >> Maybe I should move the code to a separate source file so it can be > >> built with different compiler flags, without needing #pragma? I don't > >> feel like building all gt

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-09 Thread Thomas Huth
On 09.03.2018 08:50, Gerd Hoffmann wrote: > Hi, > >> Maybe I should move the code to a separate source file so it can be >> built with different compiler flags, without needing #pragma? I don't >> feel like building all gtk code with -Wno-deprecated-declarations ... > > Hmm, that idea doesn't

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-08 Thread Gerd Hoffmann
Hi, > Maybe I should move the code to a separate source file so it can be > built with different compiler flags, without needing #pragma? I don't > feel like building all gtk code with -Wno-deprecated-declarations ... Hmm, that idea doesn't fly, seems per-object cflags don't work for object fi

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-08 Thread Gerd Hoffmann
Hi, > Hi. This gives me a new warning on FreeBSD: > > CC ui/gtk.o > /root/qemu/ui/gtk.c:2141:13: warning: 'gtk_widget_set_double_buffered' > is deprecated [-Wdeprecated-declarations] > gtk_widget_set_double_buffered(vc->gfx.drawing_area, FALSE); > ^ > /usr/local/i

Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-08 Thread Peter Maydell
On 8 March 2018 at 08:32, Gerd Hoffmann wrote: > The following changes since commit f32408f3b472a088467474ab152be3b6285b2d7b: > > misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30 +) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180