Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL] tftp: fake support for netascii protocol Type: series Message-id: 20161120170517.9181-2-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-20 Thread Vincent Bernat
❦ 19 novembre 2016 23:30 +0100, Samuel Thibault  : >> > I think you should at least issue a qemu_log_mask(LOG_UNIMP, "...") >> > call in that case. >> >> I can do that if needed. > > That'd be better indeed. Otherwise people might wonder why things are > not working. Warning that they have to do

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-19 Thread Samuel Thibault
Vincent Bernat, on Sat 19 Nov 2016 09:03:08 +0100, wrote: > ❦ 19 novembre 2016 08:32 +0100, Thomas Huth  : > > >> Some network equipments are requesting a file using the netascii > >> protocol and this is not configurable. Currently, qemu's tftpd only > >> supports the octet protocol. This commit

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-19 Thread Vincent Bernat
❦ 19 novembre 2016 08:32 +0100, Thomas Huth  : >> Some network equipments are requesting a file using the netascii >> protocol and this is not configurable. Currently, qemu's tftpd only >> supports the octet protocol. This commit makes it accept the netascii >> protocol as well but do not perform

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-18 Thread Thomas Huth
On 18.11.2016 18:51, Samuel Thibault wrote: > From: Vincent Bernat > > Some network equipments are requesting a file using the netascii > protocol and this is not configurable. Currently, qemu's tftpd only > supports the octet protocol. This commit makes it accept the netascii > protocol as well

Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol

2016-11-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL] tftp: fake support for netascii protocol Type: series Message-id: 20161118175128.17192-2-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1