Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-02 Thread Paolo Bonzini
Il 02/07/2013 09:40, Stefan Hajnoczi ha scritto: > On Mon, Jul 01, 2013 at 05:55:15PM +0200, Peter Lieven wrote: >> >> Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi : >> >>> On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: >>> >>> This patch breaks cross-version blog migration. We ne

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 05:55:15PM +0200, Peter Lieven wrote: > > Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi : > > > On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: > > > > This patch breaks cross-version blog migration. We need to control > > whether or not to use the new BLK

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-02 Thread Stefan Hajnoczi
On Mon, Jul 01, 2013 at 06:09:55PM +0200, Peter Lieven wrote: > > Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi : > > > On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: > >> > >> /* device name */ > >> len = strlen(blk->bmds->bs->device_name); > >> qemu_put_byte(f, len)

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-01 Thread Peter Lieven
Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi : > On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: > > This patch breaks cross-version blog migration. We need to control > whether or not to use the new BLK_MIG_FLAG_ZERO_BLOCK flag. > >> diff --git a/block-migration.c b/block-migr

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-01 Thread Peter Lieven
Am 01.07.2013 um 16:13 schrieb Stefan Hajnoczi : > On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: > > This patch breaks cross-version blog migration. We need to control > whether or not to use the new BLK_MIG_FLAG_ZERO_BLOCK flag. you are right the upgrade way works, but downgra

Re: [Qemu-devel] [PATCHv2 08/11] block-migration: efficiently encode zero blocks

2013-07-01 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 03:11:32PM +0200, Peter Lieven wrote: This patch breaks cross-version blog migration. We need to control whether or not to use the new BLK_MIG_FLAG_ZERO_BLOCK flag. > diff --git a/block-migration.c b/block-migration.c > index 2fd7699..99b3757 100644 > --- a/block-migratio