Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2010-01-01 Thread Gleb Natapov
On Thu, Dec 31, 2009 at 01:05:18PM -0600, Anthony Liguori wrote: > On 12/31/2009 09:42 AM, Gleb Natapov wrote: > >On Thu, Dec 31, 2009 at 08:20:06AM -0600, Anthony Liguori wrote: > >>On 12/30/2009 06:20 PM, Gleb Natapov wrote: > >>>I included only the state I need for debugging. I don't what to see

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-31 Thread Anthony Liguori
On 12/31/2009 09:42 AM, Gleb Natapov wrote: On Thu, Dec 31, 2009 at 08:20:06AM -0600, Anthony Liguori wrote: On 12/30/2009 06:20 PM, Gleb Natapov wrote: I included only the state I need for debugging. I don't what to see complete state. It will just clatter important info. Someone may find th

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-31 Thread Gleb Natapov
On Thu, Dec 31, 2009 at 08:20:06AM -0600, Anthony Liguori wrote: > On 12/30/2009 06:20 PM, Gleb Natapov wrote: > >I included only the state I need for debugging. I don't what to see > >complete state. It will just clatter important info. > > Someone may find that full state useful though. There's

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-31 Thread Gleb Natapov
On Thu, Dec 31, 2009 at 08:16:27AM -0600, Anthony Liguori wrote: > On 12/30/2009 06:23 PM, Gleb Natapov wrote: > >I've got you point. When VMState will have this cool powers you are talking > >about I'll use it. I don't see the point of bragging about something > >that doesn't exists. > > It *does

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-31 Thread Anthony Liguori
On 12/30/2009 06:20 PM, Gleb Natapov wrote: I included only the state I need for debugging. I don't what to see complete state. It will just clatter important info. Someone may find that full state useful though. There's no good reason to not show the entire device's state. Regards, Anthon

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-31 Thread Anthony Liguori
On 12/30/2009 06:23 PM, Gleb Natapov wrote: I've got you point. When VMState will have this cool powers you are talking about I'll use it. I don't see the point of bragging about something that doesn't exists. It *does* exist. The ioapic has already been converted to VMState. Regards, Anthon

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 05:07:14PM -0600, Anthony Liguori wrote: > On 12/30/2009 06:13 AM, Gleb Natapov wrote: > >On Wed, Dec 30, 2009 at 02:08:27PM +0200, Izik Eidus wrote: > >>On Wed, 30 Dec 2009 14:05:10 +0200 > >>Gleb Natapov wrote: > >> > >>>On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swir

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 05:04:53PM -0600, Anthony Liguori wrote: > On 12/30/2009 09:58 AM, Avi Kivity wrote: > >On 12/30/2009 05:53 PM, Gleb Natapov wrote: > >> > >>>This assumes there is only one ioapic. While I don't think there's > >>>a good reason to add more (the one we have is causing suffici

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 06:13 AM, Gleb Natapov wrote: On Wed, Dec 30, 2009 at 02:08:27PM +0200, Izik Eidus wrote: On Wed, 30 Dec 2009 14:05:10 +0200 Gleb Natapov wrote: On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: Knowing ioapic co

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Anthony Liguori
On 12/30/2009 09:58 AM, Avi Kivity wrote: On 12/30/2009 05:53 PM, Gleb Natapov wrote: This assumes there is only one ioapic. While I don't think there's a good reason to add more (the one we have is causing sufficient trouble), I suggest returning an array of ioapics (or include gsibase: [{ io

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Avi Kivity
On 12/30/2009 05:53 PM, Gleb Natapov wrote: This assumes there is only one ioapic. While I don't think there's a good reason to add more (the one we have is causing sufficient trouble), I suggest returning an array of ioapics (or include gsibase: [{ ioapic: object, gsibase: 0 }, { ioapic: obje

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 05:04:08PM +0200, Avi Kivity wrote: > On 12/30/2009 01:50 PM, Gleb Natapov wrote: > >Knowing ioapic configuration is very useful for the poor soles > >how need to debug guest occasionally. > >+ > >+void do_info_ioapic(Monitor *mon, QObject **ret_data) > >+{ > >+int i; >

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Avi Kivity
On 12/30/2009 01:50 PM, Gleb Natapov wrote: Knowing ioapic configuration is very useful for the poor soles how need to debug guest occasionally. + +void do_info_ioapic(Monitor *mon, QObject **ret_data) +{ +int i; +QList *list; + +*ret_data = NULL; + +if (!ioapic) +return;

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Luiz Capitulino
On Wed, 30 Dec 2009 12:01:28 + Blue Swirl wrote: > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > Knowing ioapic configuration is very useful for the poor soles > > how need to debug guest occasionally. > > > +static struct IOAPICState *ioapic; > > Ugly. I really think the monit

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 02:08:27PM +0200, Izik Eidus wrote: > On Wed, 30 Dec 2009 14:05:10 +0200 > Gleb Natapov wrote: > > > On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: > > > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > > > Knowing ioapic configuration is very useful

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Izik Eidus
On Wed, 30 Dec 2009 14:05:10 +0200 Gleb Natapov wrote: > On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: > > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > > Knowing ioapic configuration is very useful for the poor soles > > > how need to debug guest occasionally. > > > >

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Gleb Natapov
On Wed, Dec 30, 2009 at 12:01:28PM +, Blue Swirl wrote: > On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > > Knowing ioapic configuration is very useful for the poor soles > > how need to debug guest occasionally. > > > +static struct IOAPICState *ioapic; > > Ugly. I really think the

Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command

2009-12-30 Thread Blue Swirl
On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov wrote: > Knowing ioapic configuration is very useful for the poor soles > how need to debug guest occasionally. > +static struct IOAPICState *ioapic; Ugly. I really think the monitor interface needs to be changed to take an opaque parameter. The pa