Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation

2015-09-17 Thread Markus Armbruster
Eric Blake writes: > On 09/16/2015 05:06 AM, Markus Armbruster wrote: >> Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but >> that's no excuse. Move the helpers from qapi-types.py to qapi.py, and >> replace the duplicates in qapi-event.py. >> >> The generated event enumeration

Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but > that's no excuse. Move the helpers from qapi-types.py to qapi.py, and > replace the duplicates in qapi-event.py. > > The generated event enumeration type's lookup table becomes

Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:12PM +0200, Markus Armbruster wrote: > Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but > that's no excuse. Move the helpers from qapi-types.py to qapi.py, and > replace the duplicates in qapi-event.py. > > The generated event enumeration type's lo