Re: [Qemu-devel] [PATCH v8 06/27] target-arm: add secure state bit to CPREG hash

2014-10-31 Thread Greg Bellows
Fixed in v9. On 31 October 2014 07:31, Peter Maydell wrote: > On 31 October 2014 12:28, Peter Maydell wrote: > > On 30 October 2014 21:28, Greg Bellows wrote: > > >> static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r, > >> void *opaque, i

Re: [Qemu-devel] [PATCH v8 06/27] target-arm: add secure state bit to CPREG hash

2014-10-31 Thread Peter Maydell
On 30 October 2014 21:28, Greg Bellows wrote: > Added additional NS-bit to CPREG hash encoding. Updated hash lookup > locations to specify hash bit currently set to non-secure. > > Signed-off-by: Greg Bellows Some minor nits here but otherwise it looks fine. > > --- > > v5 -> v6 > - Globally r

Re: [Qemu-devel] [PATCH v8 06/27] target-arm: add secure state bit to CPREG hash

2014-10-31 Thread Peter Maydell
On 31 October 2014 12:28, Peter Maydell wrote: > On 30 October 2014 21:28, Greg Bellows wrote: >> static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r, >> void *opaque, int state, >> - int crm, int opc1, int