Re: [Qemu-devel] [PATCH v7 02/26] exec: add ram_debug_ops support

2018-02-07 Thread Brijesh Singh
On 02/07/2018 10:51 AM, Paolo Bonzini wrote: On 07/02/2018 17:06, Brijesh Singh wrote: @@ -3148,7 +3152,11 @@ MemTxResult flatview_read_continue(FlatView *fv, hwaddr addr, } else { /* RAM case */ ptr = qemu_ram_ptr_length(mr->ram_block, addr1, &l, false);

Re: [Qemu-devel] [PATCH v7 02/26] exec: add ram_debug_ops support

2018-02-07 Thread Paolo Bonzini
On 07/02/2018 17:06, Brijesh Singh wrote: > @@ -3148,7 +3152,11 @@ MemTxResult flatview_read_continue(FlatView *fv, > hwaddr addr, > } else { > /* RAM case */ > ptr = qemu_ram_ptr_length(mr->ram_block, addr1, &l, false); > -memcpy(buf, ptr, l); > +

Re: [Qemu-devel] [PATCH v7 02/26] exec: add ram_debug_ops support

2018-02-07 Thread Brijesh Singh
On 2/7/18 10:19 AM, Eric Blake wrote: > On 02/07/2018 10:06 AM, Brijesh Singh wrote: >> Currently, the guest memory access for the debug purpose is performed >> using the memcpy(). Lets extend the 'struct MemoryRegion' to include >> ram_debug_ops callbacks. The ram_debug_ops can be used to overrid

Re: [Qemu-devel] [PATCH v7 02/26] exec: add ram_debug_ops support

2018-02-07 Thread Eric Blake
On 02/07/2018 10:33 AM, Brijesh Singh wrote: [meta-comment] Your threading is off.  This email was sent with the headers: I am just looking at the my git send email script log and it seems that after sending the cover-letter patch, exchange server timeout and my script restarting send from

Re: [Qemu-devel] [PATCH v7 02/26] exec: add ram_debug_ops support

2018-02-07 Thread Eric Blake
On 02/07/2018 10:06 AM, Brijesh Singh wrote: Currently, the guest memory access for the debug purpose is performed using the memcpy(). Lets extend the 'struct MemoryRegion' to include ram_debug_ops callbacks. The ram_debug_ops can be used to override memcpy() with something else. [meta-comment]