Re: [Qemu-devel] [PATCH v6 19/27] qapi: add 'if' on union members

2018-12-08 Thread Marc-André Lureau
Hi On Thu, Dec 6, 2018 at 8:37 PM Markus Armbruster wrote: > > In the subject, s/ on / to /. > > Marc-André Lureau writes: > > > Add 'if' key to union members: > > > > { 'union': 'TestIfUnion', 'data': > > 'mem': { 'type': 'str', 'if': 'COND'} } > > > > Generated code is not changed by this p

Re: [Qemu-devel] [PATCH v6 19/27] qapi: add 'if' on union members

2018-12-06 Thread Markus Armbruster
In the subject, s/ on / to /. Marc-André Lureau writes: > Add 'if' key to union members: > > { 'union': 'TestIfUnion', 'data': > 'mem': { 'type': 'str', 'if': 'COND'} } > > Generated code is not changed by this patch but with "qapi: add #if > conditions to generated code". My suggestion on